Sign upLogin

NullVoxPopuli/meshchat

View on GitHub
Star
lib/meshchat/network/local/connection.rb

Summary

Maintainability
A
0 mins
Test Coverage

Add an empty line after magic comments. (https://github.com/bbatsov/ruby-style-guide#separate-magic-comments-from-code)
Open

require 'em-http-request'
Severity: Minor
Found in lib/meshchat/network/local/connection.rb by rubocop

Checks for a newline after the final magic comment.

Example:

# good
# frozen_string_literal: true

# Some documentation for Person
class Person
  # Some code
end

# bad
# frozen_string_literal: true
# Some documentation for Person
class Person
  # Some code
end

Ambiguous block operator. Parenthesize the method arguments if it's surely a block operator, or add a whitespace to the right of the & if it should be a binary AND. (https://github.com/bbatsov/ruby-style-guide#method-invocation-parens)
Open

          http.errback &error_callback
Severity: Minor
Found in lib/meshchat/network/local/connection.rb by rubocop

This cop checks for ambiguous operators in the first argument of a method invocation without parentheses.

Example:

# bad

# The `*` is interpreted as a splat operator but it could possibly be
# a `*` method invocation (i.e. `do_something.*(some_array)`).
do_something *some_array

Example:

# good

# With parentheses, there's no ambiguity.
do_something(*some_array)

There are no issues that match your filters.

Category
Status