Sign upLogin

NullVoxPopuli/meshchat

View on GitHub
Star
lib/meshchat/ui/display/readline_display.rb

Summary

Maintainability
A
40 mins
Test Coverage

Identical blocks of code found in 2 locations. Consider refactoring.
Open

          message_parts_for(msg) do |time, name, message, _|
            colored_time = (time.to_s + ' ').colorize(:magenta)
            colored_name = (name + ' ').colorize(:light_black)
            colored_message = message.colorize(:light_black)
Severity: Minor
Found in lib/meshchat/ui/display/readline_display.rb and 1 other location - About 20 mins to fix
lib/meshchat/ui/display/readline_display.rb on lines 38..43

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 28.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

            message_parts_for(msg) do |time, name, message, _|
              colored_time = (time.to_s + ' ').colorize(:magenta)
              colored_name = (name + ' ').colorize(:light_black)
              colored_message = message.colorize(:light_black)
Severity: Minor
Found in lib/meshchat/ui/display/readline_display.rb and 1 other location - About 20 mins to fix
lib/meshchat/ui/display/readline_display.rb on lines 63..68

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 28.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Add an empty line after magic comments. (https://github.com/bbatsov/ruby-style-guide#separate-magic-comments-from-code)
Open

module Meshchat
Severity: Minor
Found in lib/meshchat/ui/display/readline_display.rb by rubocop

Checks for a newline after the final magic comment.

Example:

# good
# frozen_string_literal: true

# Some documentation for Person
class Person
  # Some code
end

# bad
# frozen_string_literal: true
# Some documentation for Person
class Person
  # Some code
end

Useless assignment to variable - colored_to. Did you mean colored_message? (https://github.com/bbatsov/ruby-style-guide#underscore-unused-vars)
Open

            colored_to = to.colorize(:blue).bold
Severity: Minor
Found in lib/meshchat/ui/display/readline_display.rb by rubocop

This cop checks for every useless assignment to local variable in every scope. The basic idea for this cop was from the warning of ruby -cw:

assigned but unused variable - foo

Currently this cop has advanced logic that detects unreferenced reassignments and properly handles varied cases such as branch, loop, rescue, ensure, etc.

Example:

# bad

def some_method
  some_var = 1
  do_something
end

Example:

# good

def some_method
  some_var = 1
  do_something(some_var)
end

Use == if you meant to do a comparison or wrap the expression in parentheses to indicate you meant to assign in a condition. (https://github.com/bbatsov/ruby-style-guide#safe-assignment-in-condition)
Open

          if buffer = Readline.line_buffer
Severity: Minor
Found in lib/meshchat/ui/display/readline_display.rb by rubocop

This cop checks for assignments in the conditions of if/while/until.

Example:

# bad

if some_var = true
  do_something
end

Example:

# good

if some_var == true
  do_something
end

There are no issues that match your filters.

Category
Status