Sign upLogin

OCA/l10n-canada

View on GitHub
Star
account_tax_expense_include_unported/account_tax_expense_include.py

Summary

Maintainability
A
2 hrs
Test Coverage

Function compute_all has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

    def compute_all(self, cr, uid, taxes, price_unit, quantity, product=None, partner=None, force_excluded=False):
        """
        :param force_excluded: boolean used to say that we don't want to consider the value of field price_include of
            tax. It's used in encoding by line where you don't matter if you encoded a tax with that boolean to True or
            False
Severity: Minor
Found in account_tax_expense_include_unported/account_tax_expense_include.py - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function compute_all has 8 arguments (exceeds 4 allowed). Consider refactoring.
Open

    def compute_all(self, cr, uid, taxes, price_unit, quantity, product=None, partner=None, force_excluded=False):
Severity: Major
Found in account_tax_expense_include_unported/account_tax_expense_include.py - About 1 hr to fix

There are no issues that match your filters.

Category
Status