Method add_plugin_config
has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring. Open
def add_plugin_config(plugin_cfg)
config_section = plugin_cfg['config']
group_name = plugin_cfg['plugin-config']['name']
if $debug
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Cyclomatic complexity for add_plugin_config is too high. [9/6] Open
def add_plugin_config(plugin_cfg)
config_section = plugin_cfg['config']
group_name = plugin_cfg['plugin-config']['name']
if $debug
- Read upRead up
- Exclude checks
This cop checks that the cyclomatic complexity of methods is not higher than the configured maximum. The cyclomatic complexity is the number of linearly independent paths through a method. The algorithm counts decision points and adds one.
An if statement (or unless or ?:) increases the complexity by one. An else branch does not, since it doesn't add a decision point. The && operator (or keyword and) can be converted to a nested if statement, and ||/or is shorthand for a sequence of ifs, so they also add one. Loops can be said to have an exit condition, so they add one.
Cyclomatic complexity for load_global_config is too high. [7/6] Open
def load_global_config(config)
throw 'Invalid global config!' if config.nil?
reset
@default_backend_groups = config['default_backend_groups'] unless config['default_backend_groups'].nil?
- Read upRead up
- Exclude checks
This cop checks that the cyclomatic complexity of methods is not higher than the configured maximum. The cyclomatic complexity is the number of linearly independent paths through a method. The algorithm counts decision points and adds one.
An if statement (or unless or ?:) increases the complexity by one. An else branch does not, since it doesn't add a decision point. The && operator (or keyword and) can be converted to a nested if statement, and ||/or is shorthand for a sequence of ifs, so they also add one. Loops can be said to have an exit condition, so they add one.
Method load_global_config
has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring. Open
def load_global_config(config)
throw 'Invalid global config!' if config.nil?
reset
@default_backend_groups = config['default_backend_groups'] unless config['default_backend_groups'].nil?
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method add_plugin_config
has 27 lines of code (exceeds 25 allowed). Consider refactoring. Open
def add_plugin_config(plugin_cfg)
config_section = plugin_cfg['config']
group_name = plugin_cfg['plugin-config']['name']
if $debug
Method load_from_consul
has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring. Open
def load_from_consul
Odania.plugin.get_all.each_pair do |plugin_name, instances|
$logger.info "PLUGIN NAME #{plugin_name} - #{instances.count}" if $debug
instances.each do |instance|
add_backend(instance)
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"