Odania-IT/odania-gem

View on GitHub
lib/odania/config/subdomain_config.rb

Summary

Maintainability
A
2 hrs
Test Coverage

Cyclomatic complexity for generate_merged_partials is too high. [7/6]
Open

            def generate_merged_partials
                partials = retrieve_hash_path @global_config, %w(partials _general _general default)
                partials = {} if partials.nil?

                # general specific layout

This cop checks that the cyclomatic complexity of methods is not higher than the configured maximum. The cyclomatic complexity is the number of linearly independent paths through a method. The algorithm counts decision points and adds one.

An if statement (or unless or ?:) increases the complexity by one. An else branch does not, since it doesn't add a decision point. The && operator (or keyword and) can be converted to a nested if statement, and ||/or is shorthand for a sequence of ifs, so they also add one. Loops can be said to have an exit condition, so they add one.

Method generate_merged_partials has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

            def generate_merged_partials
                partials = retrieve_hash_path @global_config, %w(partials _general _general default)
                partials = {} if partials.nil?

                # general specific layout
Severity: Minor
Found in lib/odania/config/subdomain_config.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method get_layout_name has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

            def get_layout_name
                # subdomain specific layouts
                result = retrieve_hash_path @global_config, ['domains', @domain, @subdomain, 'config', 'layout']
                return result unless result.nil?

Severity: Minor
Found in lib/odania/config/subdomain_config.rb - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method get_layout_config has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

            def get_layout_config(layout)
                # subdomain specific layouts
                result = retrieve_hash_path @global_config, ['domains', @domain, @subdomain, 'layouts', layout]
                return result unless result.nil?

Severity: Minor
Found in lib/odania/config/subdomain_config.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

There are no issues that match your filters.

Category
Status