Sign upLogin

OddGreg/NineCollections

View on GitHub
Star
src/Traits/Macroable.php

Summary

Maintainability
A
0 mins
Test Coverage

Avoid using undefined variables such as '::$macros' which will lead to PHP notices.
Open

                return call_user_func_array(static::$macros[$method], $parameters);
Severity: Minor
Found in src/Traits/Macroable.php by phpmd

UndefinedVariable

Since: 2.8.0

Detects when a variable is used that has not been defined before.

Example

class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

Source https://phpmd.org/rules/cleancode.html#undefinedvariable

Avoid using undefined variables such as '::$macros' which will lead to PHP notices.
Open

                return call_user_func_array(static::$macros[$method]->bindTo($this, static::class), $parameters);
Severity: Minor
Found in src/Traits/Macroable.php by phpmd

UndefinedVariable

Since: 2.8.0

Detects when a variable is used that has not been defined before.

Example

class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

Source https://phpmd.org/rules/cleancode.html#undefinedvariable

Avoid using undefined variables such as '::$macros' which will lead to PHP notices.
Open

                return call_user_func_array(Closure::bind(static::$macros[$method], null, static::class), $parameters);
Severity: Minor
Found in src/Traits/Macroable.php by phpmd

UndefinedVariable

Since: 2.8.0

Detects when a variable is used that has not been defined before.

Example

class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

Source https://phpmd.org/rules/cleancode.html#undefinedvariable

Avoid using undefined variables such as '::$macros' which will lead to PHP notices.
Open

                return call_user_func_array(static::$macros[$method], $parameters);
Severity: Minor
Found in src/Traits/Macroable.php by phpmd

UndefinedVariable

Since: 2.8.0

Detects when a variable is used that has not been defined before.

Example

class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

Source https://phpmd.org/rules/cleancode.html#undefinedvariable

Avoid using undefined variables such as '::$macros' which will lead to PHP notices.
Open

            if (static::$macros[$method] instanceof Closure) {
Severity: Minor
Found in src/Traits/Macroable.php by phpmd

UndefinedVariable

Since: 2.8.0

Detects when a variable is used that has not been defined before.

Example

class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

Source https://phpmd.org/rules/cleancode.html#undefinedvariable

Avoid using undefined variables such as '::$macros' which will lead to PHP notices.
Open

        return isset(static::$macros[$name]);
Severity: Minor
Found in src/Traits/Macroable.php by phpmd

UndefinedVariable

Since: 2.8.0

Detects when a variable is used that has not been defined before.

Example

class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

Source https://phpmd.org/rules/cleancode.html#undefinedvariable

Avoid using undefined variables such as '::$macros' which will lead to PHP notices.
Open

            if (static::$macros[$method] instanceof Closure) {
Severity: Minor
Found in src/Traits/Macroable.php by phpmd

UndefinedVariable

Since: 2.8.0

Detects when a variable is used that has not been defined before.

Example

class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

Source https://phpmd.org/rules/cleancode.html#undefinedvariable

The method __call uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

            } else {
                return call_user_func_array(static::$macros[$method], $parameters);
            }
Severity: Minor
Found in src/Traits/Macroable.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

The method __callStatic uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

            } else {
                return call_user_func_array(static::$macros[$method], $parameters);
            }
Severity: Minor
Found in src/Traits/Macroable.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

There are no issues that match your filters.

Category
Status