Sign upLogin

Oefenweb/cakephp-edexml

View on GitHub
Star

Showing 18 of 18 total issues

File EdexmlTest.php has 453 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
App::uses('Edexml', 'Edexml.Model');

class TestEdexml extends Edexml {
Severity: Minor
Found in Test/Case/Model/EdexmlTest.php - About 6 hrs to fix

    Method testConvertStudent has 133 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function testConvertStudent() {
        $data = [
            '@key' => 'key',
            'achternaam' => 'Achternaam',
            'roepnaam' => 'Roepnaam',
    Severity: Major
    Found in Test/Case/Model/EdexmlTest.php - About 5 hrs to fix

      Method testConvertTeacher has 85 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function testConvertTeacher() {
        $data = [
            '@key' => 'key',
            'achternaam' => 'Achternaam',
            'roepnaam' => 'Roepnaam',
      Severity: Major
      Found in Test/Case/Model/EdexmlTest.php - About 3 hrs to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                if (!empty($data['EDEX']['leerlingen']['leerling'])) {
            if (!Hash::numeric(array_keys($data['EDEX']['leerlingen']['leerling']))) {
                $data['EDEX']['leerlingen']['leerling'] = [$data['EDEX']['leerlingen']['leerling']];
            }
            foreach ($data['EDEX']['leerlingen']['leerling'] as $i => $student) {
        Severity: Major
        Found in Model/Edexml.php and 1 other location - About 2 hrs to fix
        Model/Edexml.php on lines 411..419

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 130.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                if (!empty($data['EDEX']['leerkrachten']['leerkracht'])) {
            if (!Hash::numeric(array_keys($data['EDEX']['leerkrachten']['leerkracht']))) {
                $data['EDEX']['leerkrachten']['leerkracht'] = [$data['EDEX']['leerkrachten']['leerkracht']];
            }
        Severity: Major
        Found in Model/Edexml.php and 1 other location - About 2 hrs to fix
        Model/Edexml.php on lines 402..409

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 130.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        File Edexml.php has 264 lines of code (exceeds 250 allowed). Consider refactoring.
        Open

        <?php
App::uses('AppModel', 'Model');
App::uses('Xml', 'Utility');

/**
        Severity: Minor
        Found in Model/Edexml.php - About 2 hrs to fix

          Method testConvertSingleItemData has 57 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function testConvertSingleItemData() {
        $data = [
            'EDEX' => [
                'school' => [
                    'schooljaar' => '2012-2013',
          Severity: Major
          Found in Test/Case/Model/EdexmlTest.php - About 2 hrs to fix

            Function convert has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
            Open

                public function convert($data) {
        $result = [];

        $result['school'] = $this->_convertSchool($data['EDEX']['school']);
            Severity: Minor
            Found in Model/Edexml.php - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method _convertStudent has 37 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                protected function _convertStudent($student) {
        $result = [
            'key' => null,
            'date_of_birth' => null,
            'gender' => null,
            Severity: Minor
            Found in Model/Edexml.php - About 1 hr to fix

              Similar blocks of code found in 4 locations. Consider refactoring.
              Open

                  public function testParseToArrayEdexml21SampleFile() {
        $filename = CakePlugin::path('Edexml') . 'Test' . DS . 'File' . DS . 'EDEXML-2.1' . DS . 'EDEXML.Voorbeeld.2.1.xml';
        $data = $this->Edexml->parseToArray($filename);
        $this->assertTrue((bool)$data);
              Severity: Major
              Found in Test/Case/Model/EdexmlTest.php and 3 other locations - About 1 hr to fix
              Test/Case/Model/EdexmlTest.php on lines 521..528
              Test/Case/Model/EdexmlTest.php on lines 537..544
              Test/Case/Model/EdexmlTest.php on lines 569..576

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 107.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 4 locations. Consider refactoring.
              Open

                  public function testParseToArrayEdexml20VlaSampleFile() {
        $filename = CakePlugin::path('Edexml') . 'Test' . DS . 'File' . DS . 'EDEXML-2.0' . DS . 'EDEXML.Voorbeeld.2.0-Vla.xml';
        $data = $this->Edexml->parseToArray($filename);
        $this->assertTrue((bool)$data);
              Severity: Major
              Found in Test/Case/Model/EdexmlTest.php and 3 other locations - About 1 hr to fix
              Test/Case/Model/EdexmlTest.php on lines 521..528
              Test/Case/Model/EdexmlTest.php on lines 553..560
              Test/Case/Model/EdexmlTest.php on lines 569..576

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 107.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 4 locations. Consider refactoring.
              Open

                  public function testParseToArrayEdexml21VlaSampleFile() {
        $filename = CakePlugin::path('Edexml') . 'Test' . DS . 'File' . DS . 'EDEXML-2.1' . DS . 'EDEXML.Voorbeeld.2.1-Vla.xml';
        $data = $this->Edexml->parseToArray($filename);
        $this->assertTrue((bool)$data);
              Severity: Major
              Found in Test/Case/Model/EdexmlTest.php and 3 other locations - About 1 hr to fix
              Test/Case/Model/EdexmlTest.php on lines 521..528
              Test/Case/Model/EdexmlTest.php on lines 537..544
              Test/Case/Model/EdexmlTest.php on lines 553..560

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 107.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 4 locations. Consider refactoring.
              Open

                  public function testParseToArrayEdexml20SampleFile() {
        $filename = CakePlugin::path('Edexml') . 'Test' . DS . 'File' . DS . 'EDEXML-2.0' . DS . 'EDEXML.Voorbeeld.2.0.xml';
        $data = $this->Edexml->parseToArray($filename);
        $this->assertTrue((bool)$data);
              Severity: Major
              Found in Test/Case/Model/EdexmlTest.php and 3 other locations - About 1 hr to fix
              Test/Case/Model/EdexmlTest.php on lines 537..544
              Test/Case/Model/EdexmlTest.php on lines 553..560
              Test/Case/Model/EdexmlTest.php on lines 569..576

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 107.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Function _convertStudent has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
              Open

                  protected function _convertStudent($student) {
        $result = [
            'key' => null,
            'date_of_birth' => null,
            'gender' => null,
              Severity: Minor
              Found in Model/Edexml.php - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method _convertTeacher has 27 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  protected function _convertTeacher($teacher) {
        $result = [
            'key' => null,
            'date_of_birth' => null,
            'gender' => null,
              Severity: Minor
              Found in Model/Edexml.php - About 1 hr to fix

                Method convert has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    public function convert($data) {
        $result = [];

        $result['school'] = $this->_convertSchool($data['EDEX']['school']);
                Severity: Minor
                Found in Model/Edexml.php - About 1 hr to fix

                  Function _convertTeacher has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                  Open

                      protected function _convertTeacher($teacher) {
        $result = [
            'key' => null,
            'date_of_birth' => null,
            'gender' => null,
                  Severity: Minor
                  Found in Model/Edexml.php - About 45 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function _convertNames has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                  Open

                      protected function _convertNames($user) {
        $result = [
            'first_name' => '',
            'last_name' => ''
        ];
                  Severity: Minor
                  Found in Model/Edexml.php - About 25 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Severity
                  Category
                  Status
                  Source
                  Language