Oefenweb/cakephp-queue

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    public $fields = [
        'id' => ['type' => 'integer', 'null' => false, 'default' => null, 'length' => 10, 'unsigned' => true, 'key' => 'primary'],
        'task' => ['type' => 'string', 'null' => false, 'default' => null, 'key' => 'index', 'collate' => 'utf8_general_ci', 'charset' => 'utf8'],
        'data' => ['type' => 'text', 'null' => true, 'default' => null, 'collate' => 'utf8_general_ci', 'charset' => 'utf8'],
        'not_before' => ['type' => 'timestamp', 'null' => true, 'default' => null],

Found in Test/Fixture/QueuedTaskFixture.php and 1 other location - About 2 days to fix

Read up
Read up

Config/Schema/schema.php on lines 23..41

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 456.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Don't Repeat Yourself on the C2 Wiki
Duplicated Code on SourceMaking
Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    public $queued_tasks = [
        'id' => ['type' => 'integer', 'null' => false, 'default' => null, 'length' => 10, 'unsigned' => true, 'key' => 'primary'],
        'task' => ['type' => 'string', 'null' => false, 'default' => null, 'key' => 'index', 'collate' => 'utf8_general_ci', 'charset' => 'utf8'],
        'data' => ['type' => 'text', 'null' => true, 'default' => null, 'collate' => 'utf8_general_ci', 'charset' => 'utf8'],
        'not_before' => ['type' => 'timestamp', 'null' => true, 'default' => null],

Found in Config/Schema/schema.php and 1 other location - About 2 days to fix

Read up
Read up

Test/Fixture/QueuedTaskFixture.php on lines 13..31

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 456.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Don't Repeat Yourself on the C2 Wiki
Duplicated Code on SourceMaking
Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76

Function `runworker` has a Cognitive Complexity of 31 (exceeds 5 allowed). Consider refactoring.
Open

    public function runworker() {
        // Enable garbage collector (PHP >= 5.3)
        if (function_exists('gc_enable')) {
            gc_enable();
        }

Found in Console/Command/QueueShell.php - About 4 hrs to fix

Read up
Read up

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
Code is considered more complex for each "break in the linear flow of the code"
Code is considered more complex when "flow breaking structures are nested"

Further reading

Method `runworker` has 70 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function runworker() {
        // Enable garbage collector (PHP >= 5.3)
        if (function_exists('gc_enable')) {
            gc_enable();
        }

Found in Console/Command/QueueShell.php - About 2 hrs to fix

File `QueueShell.php` has 281 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
App::uses('Folder', 'Utility');
App::uses('QueuedTask', 'Model');
App::uses('AppShell', 'Console/Command');
App::uses('CakeText', 'Utility');

Found in Console/Command/QueueShell.php - About 2 hrs to fix

Method `requestJob` has 65 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function requestJob($capabilities, array $types = []) {
        $idlist = [];
        $wasFetched = [];

        $this->virtualFields['age'] = 'IFNULL(TIMESTAMPDIFF(SECOND, NOW(), not_before), 0)';

Found in Model/QueuedTask.php - About 2 hrs to fix

Method `getOptionParser` has 49 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function getOptionParser() {
        $parser = parent::getOptionParser();
        $parser->addSubcommand('add', [
            'help' => __d('queue', 'Tries to call the cli `add()` function on a task.'),
            'parser' => [

Found in Console/Command/QueueShell.php - About 1 hr to fix

Function `_getTaskConf` has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
Open

    protected function _getTaskConf() {
        if (!is_array($this->_taskConf)) {
            $this->_taskConf = [];
            foreach ($this->tasks as $task) {
                list($pluginName, $taskName) = pluginSplit($task);

Found in Console/Command/QueueShell.php - About 1 hr to fix

Read up
Read up

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
Code is considered more complex for each "break in the linear flow of the code"
Code is considered more complex when "flow breaking structures are nested"

Further reading

Method `testNotBeforeOrder` has 44 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function testNotBeforeOrder() {
        $capabilities = [
            'task1' => [
                'name' => 'task1',
                'timeout' => 100,

Found in Test/Case/Model/QueuedTaskTest.php - About 1 hr to fix

Method `initialize` has 41 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function initialize() {
        // Check for tasks inside plugins and application
        $paths = App::path('Console/Command/Task');

        foreach ($paths as $path) {

Found in Console/Command/QueueShell.php - About 1 hr to fix

Function `requestJob` has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
Open

    public function requestJob($capabilities, array $types = []) {
        $idlist = [];
        $wasFetched = [];

        $this->virtualFields['age'] = 'IFNULL(TIMESTAMPDIFF(SECOND, NOW(), not_before), 0)';

Found in Model/QueuedTask.php - About 1 hr to fix

Read up
Read up

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
Code is considered more complex for each "break in the linear flow of the code"
Code is considered more complex when "flow breaking structures are nested"

Further reading

Method `__construct` has 37 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function __construct() {
        $this->records[] = [
            'id' => 2,
            'task' => 'Example',
            'data' => 'Lorem ipsum dolor sit amet, aliquet feugiat. Convallis morbi fringilla gravida, phasellus feugiat dapibus velit nunc, pulvinar eget sollicitudin venenatis cum nullam, vivamus ut a sed, mollitia lectus. Nulla vestibulum massa neque ut et, id hendrerit sit, feugiat in taciti enim proin nibh, tempor dignissim, rhoncus duis vestibulum nunc mattis convallis.',

Found in Test/Fixture/QueuedTaskFixture.php - About 1 hr to fix

Method `testSequence` has 30 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function testSequence() {
        // Capabilities is a list of tasks the worker can run
        $capabilities = [
            'task1' => [
                'name' => 'task1',

Found in Test/Case/Model/QueuedTaskTest.php - About 1 hr to fix

Method `testCreateAndFetch` has 28 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function testCreateAndFetch() {
        // Capabilities is a list of tasks the worker can run
        $capabilities = [
            'task1' => [
                'name' => 'task1',

Found in Test/Case/Model/QueuedTaskTest.php - About 1 hr to fix

Function `initialize` has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

    public function initialize() {
        // Check for tasks inside plugins and application
        $paths = App::path('Console/Command/Task');

        foreach ($paths as $path) {

Found in Console/Command/QueueShell.php - About 1 hr to fix

Read up
Read up

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
Code is considered more complex for each "break in the linear flow of the code"
Code is considered more complex when "flow breaking structures are nested"

Further reading

Function `_addFilter` has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    protected function _addFilter(array $conditions, $key, array $values) : array {
        $include = [];
        $exclude = [];
        foreach ($values as $value) {
            if (substr($value, 0, 1) === '-') {

Found in Model/QueuedTask.php - About 25 mins to fix

Read up
Read up

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
Code is considered more complex for each "break in the linear flow of the code"
Code is considered more complex when "flow breaking structures are nested"

Further reading