OpenHPS/openhps-imu

View on GitHub
src/nodes/processing/PedometerProcessingNode.ts

Summary

Maintainability
B
5 hrs
Test Coverage

Function processPedometer has 56 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public processPedometer(data: PedometerData): Promise<number[]> {
        return new Promise((resolve) => {
            // Factor in the sampling time
            const windowSize = Math.floor(this.options.windowSize * data.frequency);
            const taoMin = this.options.minStepTime * data.frequency;
Severity: Major
Found in src/nodes/processing/PedometerProcessingNode.ts - About 2 hrs to fix

    Function process has 52 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public process(frame: DataFrame): Promise<DataFrame> {
            return new Promise((resolve, reject) => {
                // Get node data for this source object
                let pedometerData: PedometerData;
                this.getNodeData(frame.source)
    Severity: Major
    Found in src/nodes/processing/PedometerProcessingNode.ts - About 2 hrs to fix

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

                          windowMax = Math.max(this.options.minPeak, Math.min(this.options.maxPeak, Math.max(...window)));
      Severity: Minor
      Found in src/nodes/processing/PedometerProcessingNode.ts and 1 other location - About 30 mins to fix
      src/nodes/processing/PedometerProcessingNode.ts on lines 124..124

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 45.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

                  let windowMax = Math.max(this.options.minPeak, Math.min(this.options.maxPeak, Math.max(...window)));
      Severity: Minor
      Found in src/nodes/processing/PedometerProcessingNode.ts and 1 other location - About 30 mins to fix
      src/nodes/processing/PedometerProcessingNode.ts on lines 159..159

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 45.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status