Ousret/Picross-L3S6

View on GitHub
class/partie.class.rb

Summary

Maintainability
A
0 mins
Test Coverage

Use 2 (not 1) spaces for indentation.
Open

        new(grille,profile)
Severity: Minor
Found in class/partie.class.rb by rubocop

This cops checks for indentation that doesn't use the specified number of spaces.

See also the IndentationConsistency cop which is the companion to this one.

Example:

# bad
class A
 def test
  puts 'hello'
 end
end

# good
class A
  def test
    puts 'hello'
  end
end

Example: IgnoredPatterns: ['^\s*module']

# bad
module A
class B
  def test
  puts 'hello'
  end
end
end

# good
module A
class B
  def test
    puts 'hello'
  end
end
end

Missing space after #.
Open

    #* <b>profile</b> : le profile associé à la partie
Severity: Minor
Found in class/partie.class.rb by rubocop

This cop checks whether comments have a leading space after the # denoting the start of the comment. The leading space is not required for some RDoc special syntax, like #++, #--, #:nodoc, =begin- and =end comments, "shebang" directives, or rackup options.

Example:

# bad
#Some comment

# good
# Some comment

Missing space after #.
Open

    #* <b>id</b>  : l'id de la partie à charger
Severity: Minor
Found in class/partie.class.rb by rubocop

This cop checks whether comments have a leading space after the # denoting the start of the comment. The leading space is not required for some RDoc special syntax, like #++, #--, #:nodoc, =begin- and =end comments, "shebang" directives, or rackup options.

Example:

# bad
#Some comment

# good
# Some comment

Tab detected.
Open

    
Severity: Minor
Found in class/partie.class.rb by rubocop

Tab detected.
Open

        new(grille,profile)
Severity: Minor
Found in class/partie.class.rb by rubocop

Use only ascii symbols in comments.
Open

    #=== Paramètres:
Severity: Minor
Found in class/partie.class.rb by rubocop

This cop checks for non-ascii (non-English) characters in comments. You could set an array of allowed non-ascii chars in AllowedChars attribute (empty by default).

Example:

# bad
# Translates from English to 日本語。

# good
# Translates from English to Japanese

Tab detected.
Open

    #=== Paramètres:
Severity: Minor
Found in class/partie.class.rb by rubocop

Trailing whitespace detected.
Open

    
Severity: Minor
Found in class/partie.class.rb by rubocop

Use self.charger instead of Partie.charger.
Open

    def Partie.charger(id)
Severity: Minor
Found in class/partie.class.rb by rubocop

This cop checks for uses of the class/module name instead of self, when defining class/module methods.

Example:

# bad
class SomeClass
  def SomeClass.class_method
    # ...
  end
end

# good
class SomeClass
  def self.class_method
    # ...
  end
end

Use 2 (not 4) spaces for indentation.
Open

        return Partie.find_by_id(id)
Severity: Minor
Found in class/partie.class.rb by rubocop

This cops checks for indentation that doesn't use the specified number of spaces.

See also the IndentationConsistency cop which is the companion to this one.

Example:

# bad
class A
 def test
  puts 'hello'
 end
end

# good
class A
  def test
    puts 'hello'
  end
end

Example: IgnoredPatterns: ['^\s*module']

# bad
module A
class B
  def test
  puts 'hello'
  end
end
end

# good
module A
class B
  def test
    puts 'hello'
  end
end
end

Tab detected.
Open

    #la methode new() est private pour cette classe
Severity: Minor
Found in class/partie.class.rb by rubocop

Tab detected.
Open

    private_class_method :new
Severity: Minor
Found in class/partie.class.rb by rubocop

Tab detected.
Open

    def initialize(grille,profile)#:nodoc:
Severity: Minor
Found in class/partie.class.rb by rubocop

Use self.configurer instead of Partie.configurer.
Open

    def Partie.configurer(grille,profile)
Severity: Minor
Found in class/partie.class.rb by rubocop

This cop checks for uses of the class/module name instead of self, when defining class/module methods.

Example:

# bad
class SomeClass
  def SomeClass.class_method
    # ...
  end
end

# good
class SomeClass
  def self.class_method
    # ...
  end
end

Tab detected.
Open

    #=== Variables d'instance ===
Severity: Minor
Found in class/partie.class.rb by rubocop

Tab detected.
Open

    #=== Methode de classe permetant de creer une partie
Severity: Minor
Found in class/partie.class.rb by rubocop

Tab detected.
Open

    def Partie.configurer(grille,profile)
Severity: Minor
Found in class/partie.class.rb by rubocop

Unnecessary utf-8 encoding comment.
Open

# encoding: UTF-8
Severity: Minor
Found in class/partie.class.rb by rubocop

Use 2 (not 8) spaces for indentation.
Open

            self.save
Severity: Minor
Found in class/partie.class.rb by rubocop

This cops checks for indentation that doesn't use the specified number of spaces.

See also the IndentationConsistency cop which is the companion to this one.

Example:

# bad
class A
 def test
  puts 'hello'
 end
end

# good
class A
  def test
    puts 'hello'
  end
end

Example: IgnoredPatterns: ['^\s*module']

# bad
module A
class B
  def test
  puts 'hello'
  end
end
end

# good
module A
class B
  def test
    puts 'hello'
  end
end
end

Missing space after #.
Open

    #@grille    #grille de jeu 
Severity: Minor
Found in class/partie.class.rb by rubocop

This cop checks whether comments have a leading space after the # denoting the start of the comment. The leading space is not required for some RDoc special syntax, like #++, #--, #:nodoc, =begin- and =end comments, "shebang" directives, or rackup options.

Example:

# bad
#Some comment

# good
# Some comment

Missing space after #.
Open

    #la methode new() est private pour cette classe
Severity: Minor
Found in class/partie.class.rb by rubocop

This cop checks whether comments have a leading space after the # denoting the start of the comment. The leading space is not required for some RDoc special syntax, like #++, #--, #:nodoc, =begin- and =end comments, "shebang" directives, or rackup options.

Example:

# bad
#Some comment

# good
# Some comment

Missing space after #.
Open

    #* <b>grille</b>  : grille associé à la partie
Severity: Minor
Found in class/partie.class.rb by rubocop

This cop checks whether comments have a leading space after the # denoting the start of the comment. The leading space is not required for some RDoc special syntax, like #++, #--, #:nodoc, =begin- and =end comments, "shebang" directives, or rackup options.

Example:

# bad
#Some comment

# good
# Some comment

Space missing after comma.
Open

    def Partie.configurer(grille,profile)
Severity: Minor
Found in class/partie.class.rb by rubocop

Checks for comma (,) not followed by some kind of space.

Example:

# bad
[1,2]
{ foo:bar,}

# good
[1, 2]
{ foo:bar, }

Tab detected.
Open

    #
Severity: Minor
Found in class/partie.class.rb by rubocop

Use only ascii symbols in comments.
Open

    #* <b>id</b>  : l'id de la partie à charger
Severity: Minor
Found in class/partie.class.rb by rubocop

This cop checks for non-ascii (non-English) characters in comments. You could set an array of allowed non-ascii chars in AllowedChars attribute (empty by default).

Example:

# bad
# Translates from English to 日本語。

# good
# Translates from English to Japanese

Omit the parentheses in defs when the method doesn't accept any arguments.
Open

    def sauver()
Severity: Minor
Found in class/partie.class.rb by rubocop

This cop checks for parentheses in the definition of a method, that does not take any arguments. Both instance and class/singleton methods are checked.

Example:

# bad
def foo()
  # does a thing
end

# good
def foo
  # does a thing
end

# also good
def foo() does_a_thing end

Example:

# bad
def Baz.foo()
  # does a thing
end

# good
def Baz.foo
  # does a thing
end

Extra blank line detected.
Open


    #=== Methode de classe permetant de creer une partie
Severity: Minor
Found in class/partie.class.rb by rubocop

This cops checks for two or more consecutive blank lines.

Example:

# bad - It has two empty lines.
some_method
# one empty line
# two empty lines
some_method

# good
some_method
# one empty line
some_method

Missing space after #.
Open

    self.grilleID  = grille     #l'id de la grille associé à la partie
Severity: Minor
Found in class/partie.class.rb by rubocop

This cop checks whether comments have a leading space after the # denoting the start of the comment. The leading space is not required for some RDoc special syntax, like #++, #--, #:nodoc, =begin- and =end comments, "shebang" directives, or rackup options.

Example:

# bad
#Some comment

# good
# Some comment

Missing space after #.
Open

    self.profileID = profile     #l'id du profile associé à la partie
Severity: Minor
Found in class/partie.class.rb by rubocop

This cop checks whether comments have a leading space after the # denoting the start of the comment. The leading space is not required for some RDoc special syntax, like #++, #--, #:nodoc, =begin- and =end comments, "shebang" directives, or rackup options.

Example:

# bad
#Some comment

# good
# Some comment

Tab detected.
Open

    #============================
Severity: Minor
Found in class/partie.class.rb by rubocop

Tab detected.
Open

    self.grilleID  = grille     #l'id de la grille associé à la partie
Severity: Minor
Found in class/partie.class.rb by rubocop

Tab detected.
Open

    self.profileID = profile     #l'id du profile associé à la partie
Severity: Minor
Found in class/partie.class.rb by rubocop

Unnecessary spacing detected.
Open

    self.profileID = profile     #l'id du profile associé à la partie
Severity: Minor
Found in class/partie.class.rb by rubocop

This cop checks for extra/unnecessary whitespace.

Example:

# good if AllowForAlignment is true
name      = "RuboCop"
# Some comment and an empty line

website  += "/bbatsov/rubocop" unless cond
puts        "rubocop"          if     debug

# bad for any configuration
set_app("RuboCop")
website  = "https://github.com/bbatsov/rubocop"

Inconsistent indentation detected.
Open

    self.grilleID  = grille     #l'id de la grille associé à la partie
Severity: Minor
Found in class/partie.class.rb by rubocop

This cops checks for inconsistent indentation.

Example:

class A
  def test
    puts 'hello'
     puts 'world'
  end
end

Space missing after comma.
Open

        new(grille,profile)
Severity: Minor
Found in class/partie.class.rb by rubocop

Checks for comma (,) not followed by some kind of space.

Example:

# bad
[1,2]
{ foo:bar,}

# good
[1, 2]
{ foo:bar, }

Surrounding space missing for operator <.
Open

class Partie<ActiveRecord::Base
Severity: Minor
Found in class/partie.class.rb by rubocop

Checks that operators have space around them, except for ** which should not have surrounding space.

Example:

# bad
total = 3*4
"apple"+"juice"
my_number = 38/4
a ** b

# good
total = 3 * 4
"apple" + "juice"
my_number = 38 / 4
a**b

Tab detected.
Open

    
Severity: Minor
Found in class/partie.class.rb by rubocop

Incorrect indentation detected (column 4 instead of 1).
Open

    #attr_reader :grille,:profile
Severity: Minor
Found in class/partie.class.rb by rubocop

This cops checks the indentation of comments.

Example:

# bad
  # comment here
def method_name
end

  # comment here
a = 'hello'

# yet another comment
  if true
    true
  end

# good
# comment here
def method_name
end

# comment here
a = 'hello'

# yet another comment
if true
  true
end

Incorrect indentation detected (column 1 instead of 4).
Open

    #* <b>id</b>  : l'id de la partie à charger
Severity: Minor
Found in class/partie.class.rb by rubocop

This cops checks the indentation of comments.

Example:

# bad
  # comment here
def method_name
end

  # comment here
a = 'hello'

# yet another comment
  if true
    true
  end

# good
# comment here
def method_name
end

# comment here
a = 'hello'

# yet another comment
if true
  true
end

Inconsistent indentation detected.
Open

    def sauver()
            self.save
    end 
Severity: Minor
Found in class/partie.class.rb by rubocop

This cops checks for inconsistent indentation.

Example:

class A
  def test
    puts 'hello'
     puts 'world'
  end
end

Tab detected.
Open

    end
Severity: Minor
Found in class/partie.class.rb by rubocop

Tab detected.
Open

    #* <b>id</b>  : l'id de la partie à charger
Severity: Minor
Found in class/partie.class.rb by rubocop

Missing top-level class documentation comment.
Open

class Partie<ActiveRecord::Base
Severity: Minor
Found in class/partie.class.rb by rubocop

This cop checks for missing top-level documentation of classes and modules. Classes with no body are exempt from the check and so are namespace modules - modules that have nothing in their bodies except classes, other modules, or constant definitions.

The documentation requirement is annulled if the class or module has a "#:nodoc:" comment next to it. Likewise, "#:nodoc: all" does the same for all its children.

Example:

# bad
class Person
  # ...
end

# good
# Description/Explanation of Person class
class Person
  # ...
end

Tab detected.
Open

    #* <b>grille</b>  : grille associé à la partie
Severity: Minor
Found in class/partie.class.rb by rubocop

Tab detected.
Open

    #
Severity: Minor
Found in class/partie.class.rb by rubocop

Trailing whitespace detected.
Open

    end 
Severity: Minor
Found in class/partie.class.rb by rubocop

Use 2 (not 3) spaces for indentation.
Open

    super()
Severity: Minor
Found in class/partie.class.rb by rubocop

This cops checks for indentation that doesn't use the specified number of spaces.

See also the IndentationConsistency cop which is the companion to this one.

Example:

# bad
class A
 def test
  puts 'hello'
 end
end

# good
class A
  def test
    puts 'hello'
  end
end

Example: IgnoredPatterns: ['^\s*module']

# bad
module A
class B
  def test
  puts 'hello'
  end
end
end

# good
module A
class B
  def test
    puts 'hello'
  end
end
end

Missing space after #.
Open

    #@profile   #profile du joueur
Severity: Minor
Found in class/partie.class.rb by rubocop

This cop checks whether comments have a leading space after the # denoting the start of the comment. The leading space is not required for some RDoc special syntax, like #++, #--, #:nodoc, =begin- and =end comments, "shebang" directives, or rackup options.

Example:

# bad
#Some comment

# good
# Some comment

Incorrect indentation detected (column 4 instead of 1).
Open

    #=== Methode de classe permetant de charger une partie
Severity: Minor
Found in class/partie.class.rb by rubocop

This cops checks the indentation of comments.

Example:

# bad
  # comment here
def method_name
end

  # comment here
a = 'hello'

# yet another comment
  if true
    true
  end

# good
# comment here
def method_name
end

# comment here
a = 'hello'

# yet another comment
if true
  true
end

Put a space before an end-of-line comment.
Open

    def initialize(grille,profile)#:nodoc:
Severity: Minor
Found in class/partie.class.rb by rubocop

This cop checks for missing space between a token and a comment on the same line.

Example:

# bad
1 + 1# this operation does ...

# good
1 + 1 # this operation does ...

Tab detected.
Open

    #@grille    #grille de jeu 
Severity: Minor
Found in class/partie.class.rb by rubocop

Tab detected.
Open

    #@profile   #profile du joueur
Severity: Minor
Found in class/partie.class.rb by rubocop

Tab detected.
Open

    #* <b>profile</b> : le profile associé à la partie
Severity: Minor
Found in class/partie.class.rb by rubocop

Space missing after comma.
Open

    def initialize(grille,profile)#:nodoc:
Severity: Minor
Found in class/partie.class.rb by rubocop

Checks for comma (,) not followed by some kind of space.

Example:

# bad
[1,2]
{ foo:bar,}

# good
[1, 2]
{ foo:bar, }

Tab detected.
Open

    end
Severity: Minor
Found in class/partie.class.rb by rubocop

Use only ascii symbols in comments.
Open

    self.grilleID  = grille     #l'id de la grille associé à la partie
Severity: Minor
Found in class/partie.class.rb by rubocop

This cop checks for non-ascii (non-English) characters in comments. You could set an array of allowed non-ascii chars in AllowedChars attribute (empty by default).

Example:

# bad
# Translates from English to 日本語。

# good
# Translates from English to Japanese

Redundant return detected.
Open

        return Partie.find_by_id(id)
Severity: Minor
Found in class/partie.class.rb by rubocop

This cop checks for redundant return expressions.

Example:

def test
  return something
end

def test
  one
  two
  three
  return something
end

It should be extended to handle methods whose body is if/else or a case expression with a default branch.

Inconsistent indentation detected.
Open

    self.profileID = profile     #l'id du profile associé à la partie
Severity: Minor
Found in class/partie.class.rb by rubocop

This cops checks for inconsistent indentation.

Example:

class A
  def test
    puts 'hello'
     puts 'world'
  end
end

Missing space after #.
Open

    #attr_reader :grille,:profile
Severity: Minor
Found in class/partie.class.rb by rubocop

This cop checks whether comments have a leading space after the # denoting the start of the comment. The leading space is not required for some RDoc special syntax, like #++, #--, #:nodoc, =begin- and =end comments, "shebang" directives, or rackup options.

Example:

# bad
#Some comment

# good
# Some comment

Trailing whitespace detected.
Open

    #@grille    #grille de jeu 
Severity: Minor
Found in class/partie.class.rb by rubocop

Use only ascii symbols in comments.
Open

    #=== Paramètres:
Severity: Minor
Found in class/partie.class.rb by rubocop

This cop checks for non-ascii (non-English) characters in comments. You could set an array of allowed non-ascii chars in AllowedChars attribute (empty by default).

Example:

# bad
# Translates from English to 日本語。

# good
# Translates from English to Japanese

Redundant self detected.
Open

            self.save
Severity: Minor
Found in class/partie.class.rb by rubocop

This cop checks for redundant uses of self.

The usage of self is only needed when:

  • Sending a message to same object with zero arguments in presence of a method name clash with an argument or a local variable.

  • Calling an attribute writer to prevent an local variable assignment.

Note, with using explicit self you can only send messages with public or protected scope, you cannot send private messages this way.

Note we allow uses of self with operators because it would be awkward otherwise.

Example:

# bad
def foo(bar)
  self.baz
end

# good
def foo(bar)
  self.bar  # Resolves name clash with the argument.
end

def foo
  bar = 1
  self.bar  # Resolves name clash with the local variable.
end

def foo
  %w[x y z].select do |bar|
    self.bar == bar  # Resolves name clash with argument of the block.
  end
end

Use 2 (not 1) spaces for indentation.
Open

    private_class_method :new
Severity: Minor
Found in class/partie.class.rb by rubocop

This cops checks for indentation that doesn't use the specified number of spaces.

See also the IndentationConsistency cop which is the companion to this one.

Example:

# bad
class A
 def test
  puts 'hello'
 end
end

# good
class A
  def test
    puts 'hello'
  end
end

Example: IgnoredPatterns: ['^\s*module']

# bad
module A
class B
  def test
  puts 'hello'
  end
end
end

# good
module A
class B
  def test
    puts 'hello'
  end
end
end

Tab detected.
Open

    #=== Paramètres:
Severity: Minor
Found in class/partie.class.rb by rubocop

Trailing whitespace detected.
Open

    
Severity: Minor
Found in class/partie.class.rb by rubocop

Use only ascii symbols in comments.
Open

    #* <b>grille</b>  : grille associé à la partie
Severity: Minor
Found in class/partie.class.rb by rubocop

This cop checks for non-ascii (non-English) characters in comments. You could set an array of allowed non-ascii chars in AllowedChars attribute (empty by default).

Example:

# bad
# Translates from English to 日本語。

# good
# Translates from English to Japanese

Use only ascii symbols in comments.
Open

    #* <b>profile</b> : le profile associé à la partie
Severity: Minor
Found in class/partie.class.rb by rubocop

This cop checks for non-ascii (non-English) characters in comments. You could set an array of allowed non-ascii chars in AllowedChars attribute (empty by default).

Example:

# bad
# Translates from English to 日本語。

# good
# Translates from English to Japanese

Use empty lines between method definitions.
Open

    def Partie.configurer(grille,profile)
Severity: Minor
Found in class/partie.class.rb by rubocop

This cop checks whether method definitions are separated by one empty line.

NumberOfEmptyLines can be and integer (e.g. 1 by default) or an array (e.g. [1, 2]) to specificy a minimum and a maximum of empty lines.

AllowAdjacentOneLineDefs can be used to configure is adjacent one line methods definitions are an offense

Example:

# bad
def a
end
def b
end

Example:

# good
def a
end

def b
end

Unnecessary spacing detected.
Open

    self.grilleID  = grille     #l'id de la grille associé à la partie
Severity: Minor
Found in class/partie.class.rb by rubocop

This cop checks for extra/unnecessary whitespace.

Example:

# good if AllowForAlignment is true
name      = "RuboCop"
# Some comment and an empty line

website  += "/bbatsov/rubocop" unless cond
puts        "rubocop"          if     debug

# bad for any configuration
set_app("RuboCop")
website  = "https://github.com/bbatsov/rubocop"

Inconsistent indentation detected.
Open

    def Partie.charger(id)
        return Partie.find_by_id(id)
    end
Severity: Minor
Found in class/partie.class.rb by rubocop

This cops checks for inconsistent indentation.

Example:

class A
  def test
    puts 'hello'
     puts 'world'
  end
end

Use only ascii symbols in comments.
Open

    self.profileID = profile     #l'id du profile associé à la partie
Severity: Minor
Found in class/partie.class.rb by rubocop

This cop checks for non-ascii (non-English) characters in comments. You could set an array of allowed non-ascii chars in AllowedChars attribute (empty by default).

Example:

# bad
# Translates from English to 日本語。

# good
# Translates from English to Japanese

There are no issues that match your filters.

Category
Status