PHPSocialNetwork/phpfastcache-bundle

View on GitHub
src/Command/PhpfastcacheSetCommand.php

Summary

Maintainability
B
5 hrs
Test Coverage

Method execute has 41 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    protected function execute(InputInterface $input, OutputInterface $output)
    {
        $io = new SymfonyStyle($input, $output);
        $caches = $this->parameters;

Severity: Minor
Found in src/Command/PhpfastcacheSetCommand.php - About 1 hr to fix

    Function execute has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
    Open

        protected function execute(InputInterface $input, OutputInterface $output)
        {
            $io = new SymfonyStyle($input, $output);
            $caches = $this->parameters;
    
    
    Severity: Minor
    Found in src/Command/PhpfastcacheSetCommand.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method configure has 31 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        protected function configure()
        {
            $this
              ->setName('phpfastcache:set')
              ->setDescription('Set phpfastcache cache value')
    Severity: Minor
    Found in src/Command/PhpfastcacheSetCommand.php - About 1 hr to fix

      Avoid too many return statements within this method.
      Open

              return $string;
      Severity: Major
      Found in src/Command/PhpfastcacheSetCommand.php - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                    return (array) $jsonArray;
        Severity: Major
        Found in src/Command/PhpfastcacheSetCommand.php - About 30 mins to fix

          Function autoTypeCast has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

              protected function autoTypeCast($string)
              {
                  if(\in_array(\strtolower($string), ['true', 'false'], true)){
                      return $string === 'true';
                  }
          Severity: Minor
          Found in src/Command/PhpfastcacheSetCommand.php - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Avoid variables with short names like $io. Configured minimum length is 3.
          Open

                  $io = new SymfonyStyle($input, $output);

          ShortVariable

          Since: 0.2

          Detects when a field, local, or parameter has a very short name.

          Example

          class Something {
              private $q = 15; // VIOLATION - Field
              public static function main( array $as ) { // VIOLATION - Formal
                  $r = 20 + $this->q; // VIOLATION - Local
                  for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
                      $r += $this->q;
                  }
              }
          }

          Source https://phpmd.org/rules/naming.html#shortvariable

          There are no issues that match your filters.

          Category
          Status