PHPSocialNetwork/phpfastcache-bundle

View on GitHub
src/Twig/HumanReadableExtension/Extension.php

Summary

Maintainability
A
0 mins
Test Coverage

Remove error control operator '@' on line 49.
Open

    public function size_format($bytes, $decimals = 2, $octetFormat = false, $separator = '')
    {
        $bytes = (int)$bytes;
        $sz = 'BKMGTP';
        $factor = floor((\strlen($bytes) - 1) / 3);

ErrorControlOperator

Error suppression should be avoided if possible as it doesn't just suppress the error, that you are trying to stop, but will also suppress errors that you didn't predict would ever occur. Consider changing error_reporting() level and/or setting up your own error handler.

Example

function foo($filePath) {
    $file = @fopen($filPath); // hides exceptions
    $key = @$array[$notExistingKey]; // assigns null to $key
}

Source http://phpmd.org/rules/cleancode.html#errorcontroloperator

Missing class import via use statement (line '31', column '15').
Open

          new \Twig_SimpleFilter('sizeFormat', [$this, 'size_format']),

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Avoid variables with short names like $sz. Configured minimum length is 3.
Open

        $sz = 'BKMGTP';

ShortVariable

Since: 0.2

Detects when a field, local, or parameter has a very short name.

Example

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Source https://phpmd.org/rules/naming.html#shortvariable

The method size_format is not named in camelCase.
Open

    public function size_format($bytes, $decimals = 2, $octetFormat = false, $separator = '')
    {
        $bytes = (int)$bytes;
        $sz = 'BKMGTP';
        $factor = floor((\strlen($bytes) - 1) / 3);

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

There are no issues that match your filters.

Category
Status