Sign upLogin

PoweredLocal/vrata

View on GitHub
Star
app/Services/RestBatchResponse.php

Summary

Maintainability
A
0 mins
Test Coverage

Avoid using static access to class '\App\Presenters\JSONPresenter' in method 'getResponses'.
Open

            return JSONPresenter::safeDecode($response);
Severity: Minor
Found in app/Services/RestBatchResponse.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

There must be one blank line after the namespace declaration
Open

namespace App\Services;
Severity: Minor
Found in app/Services/RestBatchResponse.php by phpcodesniffer

Inline control structures are not allowed
Open

            if ($decoded === null) return $carry;
Severity: Minor
Found in app/Services/RestBatchResponse.php by phpcodesniffer

Expected 1 newline at end of file; 0 found
Open

}
Severity: Minor
Found in app/Services/RestBatchResponse.php by phpcodesniffer

There are no issues that match your filters.

Category
Status