Sign upLogin

ProjectCacophony/Gateway

View on GitHub
Star
pkg/whitelist/checker.go

Summary

Maintainability
A
2 hrs
Test Coverage

Similar blocks of code found in 2 locations. Consider refactoring.
Open

func (c *Checker) IsWhitelisted(guildID string) bool {
    if !c.enable {
        return true
    }
Severity: Minor
Found in pkg/whitelist/checker.go and 1 other location - About 35 mins to fix
pkg/whitelist/checker.go on lines 109..123

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 107.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

func (c *Checker) IsBlacklisted(guildID string) bool {
    if !c.enable {
        return false
    }
Severity: Minor
Found in pkg/whitelist/checker.go and 1 other location - About 35 mins to fix
pkg/whitelist/checker.go on lines 93..107

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 107.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

            if err != nil && err != redis.Nil {
                raven.CaptureError(err, nil)
                c.logger.Error("failed to retrieve blacklist", zap.Error(err))
            } else {
                c.blacklistLock.Lock()
Severity: Minor
Found in pkg/whitelist/checker.go and 1 other location - About 35 mins to fix
pkg/whitelist/checker.go on lines 65..73

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 105.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

            if err != nil && err != redis.Nil {
                raven.CaptureError(err, nil)
                c.logger.Error("failed to retrieve whitelist", zap.Error(err))
            } else {
                c.whitelistLock.Lock()
Severity: Minor
Found in pkg/whitelist/checker.go and 1 other location - About 35 mins to fix
pkg/whitelist/checker.go on lines 76..84

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 105.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

exported type Checker should have comment or be unexported
Open

type Checker struct {
Severity: Minor
Found in pkg/whitelist/checker.go by golint

exported method Checker.IsWhitelisted should have comment or be unexported
Open

func (c *Checker) IsWhitelisted(guildID string) bool {
Severity: Minor
Found in pkg/whitelist/checker.go by golint

exported function NewChecker should have comment or be unexported
Open

func NewChecker(
Severity: Minor
Found in pkg/whitelist/checker.go by golint

exported method Checker.Start should have comment or be unexported
Open

func (c *Checker) Start() error {
Severity: Minor
Found in pkg/whitelist/checker.go by golint

exported method Checker.IsBlacklisted should have comment or be unexported
Open

func (c *Checker) IsBlacklisted(guildID string) bool {
Severity: Minor
Found in pkg/whitelist/checker.go by golint

exported method Checker.GetWhitelist should have comment or be unexported
Open

func (c *Checker) GetWhitelist() []string {
Severity: Minor
Found in pkg/whitelist/checker.go by golint

exported method Checker.GetBlacklist should have comment or be unexported
Open

func (c *Checker) GetBlacklist() []string {
Severity: Minor
Found in pkg/whitelist/checker.go by golint

There are no issues that match your filters.

Category
Status