RackHD/on-http

Function getManagerSerialInterface has 47 lines of code (exceeds 25 allowed). Consider refactoring.

Open

var getManagerSerialInterface = controller(function (req, res) {
    var identifier = req.swagger.params.identifier.value;
    var options = redfish.makeOptions(req, res);
    var index = req.swagger.params.index.raw;

Function create has 47 lines of code (exceeds 25 allowed). Consider refactoring.

Open

module.exports = function create(__, ___, injector) {
    injector = injector || require('../../index.js').injector;
    var _ = injector.get('_');
    var swaggerService = injector.get('Http.Services.Swagger');
    var conf = injector.get('Services.Configuration');

Function swaggerFactory has 15 arguments (exceeds 4 allowed). Consider refactoring.

Open

    Promise,
    Errors,
    _,
    injector,
    views,

Function UPnPServiceFactory has 15 arguments (exceeds 4 allowed). Consider refactoring.

Open

    _,
    waterline,
    Logger,
    Profiles,
    Promise,

Identical blocks of code found in 2 locations. Consider refactoring.

Open

            return nodeApi.setNodeWorkflowById({
                name: graphName,
                options: graphOptions
            }, identifier)
            .then(function(graph) {

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

    return redfish.getVendorNameById(identifier)
    .then(function(result){
        identifier = result.node.id;
        if (result.vendor === 'Dell') {
            var graph = {

• Read up
  Read up

Function walkDirectory has 46 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    StaticFilesApiService.prototype.walkDirectory = function(dir) {
        return new Promise(function(resolve, reject) {
            var walkResults = [];
            if (typeof dir !== 'string') {
                console.error("[ERROR] Object of type " + typeof dir + 

Similar blocks of code found in 2 locations. Consider refactoring.

Open

            if(conf.taskRoot) {
                var taskRoot = skuRoot + path.resolve('/', conf.taskRoot);
                cleanup = unloadWorkflowItems(skuid, taskRoot, waterline.taskdefinitions);
                promises.push(Promise.all(cleanup));
            }

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

            if(conf.workflowRoot) {
                var workflowRoot = skuRoot + path.resolve('/', conf.workflowRoot);
                cleanup = unloadWorkflowItems(skuid, workflowRoot, waterline.graphdefinitions);
                promises.push(Promise.all(cleanup));
            }

• Read up
  Read up

Function tagApiServiceFactory has 45 lines of code (exceeds 25 allowed). Consider refactoring.

Open

function tagApiServiceFactory(
    waterline,
    Promise,
    workflowApiService,
    Errors,

Function listManagerSerialInterfaces has 44 lines of code (exceeds 25 allowed). Consider refactoring.

Open

var listManagerSerialInterfaces = controller(function (req, res) {
    var identifier = req.swagger.params.identifier.value;
    var options = redfish.makeOptions(req, res, identifier);

    return redfish.getVendorNameById(identifier)

Function doBootImage has 44 lines of code (exceeds 25 allowed). Consider refactoring.

Open

var doBootImage = controller(function(req,res) {
    var identifier = req.swagger.params.identifier.value;
    var payload = req.swagger.params.payload.value;

    return nodeApi.getNodeByIdentifier(identifier)

Function redfishApiServiceFactory has 14 arguments (exceeds 4 allowed). Consider refactoring.

Open

    configuration,
    Logger,
    Promise,
    _,
    nodeFs,

Function httpServiceFactory has 14 arguments (exceeds 4 allowed). Consider refactoring.

Open

    eventsProtocol,
    configuration,
    lookupService,
    swagger,
    Logger,

Identical blocks of code found in 2 locations. Consider refactoring.

Open

                    waterline.nodes.getNodeById(oldNode.id)
                    .then(function (newNode) {
                        return eventsProtocol.publishNodeAttrEvent(oldNode, newNode, 'obms');
                    })
                    .catch(function (error) {

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    if (req.body.type) {
        req.body.name = Constants.WorkItems.Pollers[req.body.type.toUpperCase()];
        delete req.body.type;
    }

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    TemplateApiService.prototype.templatesLibPut = function (name, body, scope) {
        var self = this;
        return self.FileStreaming(name, body, scope)
            .then (function(data){
                return taskgraphService.templatesLibPut(name, data, scope);

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

                        return waterline.nodes.getNodeById(oldNode.id)
                        .then(function(newNode) {
                            return eventsProtocol.publishNodeAttrEvent(oldNode, newNode, 'obms');
                        })
                        .catch(function (error) {

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    if (req.query.type) {
        req.query.name = Constants.WorkItems.Pollers[req.query.type.toUpperCase()];
        delete req.query.type;
    }

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    ProfileApiService.prototype.profilesPutLibByName = function (name, body, scope) {
        var self = this;
        return self.FileStreaming(name, body, scope)
            .then (function(data){
                return taskgraphService.profilesPutLibByName(name, data, scope);

• Read up
  Read up