RackHD/on-http

Similar blocks of code found in 2 locations. Consider refactoring.

Open

var obmsDefinitionsGetByName = controller(function(req) {
    var schemaUid = nameSpace + req.swagger.params.name.value;
    var schema = schemaApiService.getSchema(schemaUid);
    if (schema) {
        return schema;

• Read up
  Read up

Function listSimpleStorage has 66 lines of code (exceeds 25 allowed). Consider refactoring.

Open

var listSimpleStorage = controller(function(req, res)  {
    var identifier = req.swagger.params.identifier.value;

    return redfish.getVendorNameById(identifier)
    .then(function(result){

Function wsmanServiceFactory has 66 lines of code (exceeds 25 allowed). Consider refactoring.

Open

function wsmanServiceFactory(
    waterline,
    encryption,
    configuration,
    WsmanTool,

File obm-api-service.js has 276 lines of code (exceeds 250 allowed). Consider refactoring.

Open

// Copyright 2016, EMC, Inc.

'use strict';

var di = require('di');

Function installPack has 65 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    SkuPackService.prototype.installPack = function(fromRoot, skuid) {
        var self = this;
        var contents;
        return fs.readFileAsync(fromRoot + '/config.json')
        .then(function(fileContents) {

Similar blocks of code found in 2 locations. Consider refactoring.

Open

        case 'chassis':
            return nodeApi.getNodeByIdentifier(identifier)
            .then(function(node) {
                return _.filter(node.relations, function(relation) {
                    return relation.relationType === 'enclosedBy';

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

        case 'system':
            return nodeApi.getNodeById(identifier)
            .then(function(node) {
                return _.filter(node.relations, function(relation) {
                    return relation.relationType === 'encloses';

• Read up
  Read up

Function postNode has 64 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    NodeApiService.prototype.postNode = function(body) {
        var nodeBody = _.omit(body, ['obms', 'ibms']);
        var obmBody = body.obms || body.obmSettings || null;
        var ibmBody = body.ibms || null;

Function getDrive has 63 lines of code (exceeds 25 allowed). Consider refactoring.

Open

var getDrive = controller(function(req, res)  {
    var identifier = req.swagger.params.identifier.value;
    var index = req.swagger.params.index.value;
    var driveIndex = req.swagger.params.driveIndex.value;

Function addHotspare has 62 lines of code (exceeds 25 allowed). Consider refactoring.

Open

var addHotspare = controller(function(req,res) {
    var identifier = req.swagger.params.identifier.value;
    var driveIndex = req.swagger.params.driveIndex.value;
    var payload = req.swagger.params.payload.value;
    /*

Function getSerialNumber has 61 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    function getSerialNumber(amqpMessage) {
        //amqpMessage.data.originOfCondition = "Disk.Bay.1-0";
        if (amqpMessage.data.OriginOfCondition !== null && amqpMessage.data.OriginOfCondition  !== undefined) {
        var diskType;
        var splitAlertName = amqpMessage.data.OriginOfCondition.split(".");

Function listStorage has 60 lines of code (exceeds 25 allowed). Consider refactoring.

Open

var listStorage = controller(function (req, res) {
    var identifier = req.swagger.params.identifier.value;
    return redfish.getVendorNameById(identifier)
    .then(function (result) {
        identifier = result.node.id;

Function addRelation has 60 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    NodeApiService.prototype.addRelation = function addRelation(node, type, targets) {
        if (!(node && type && targets)) {
            return;
        }
        return waterline.nodes.addFieldIfNotExistByIdentifier(node.id, "relations", [])

Identical blocks of code found in 2 locations. Consider refactoring.

Open

            return Promise.try(function() {
                assert.string(identifier, 'invalid identifier specified: ' + identifier);
                return waterline.nodes.needByIdentifier(identifier);
            })
            .then(function(node) {

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

                            case "inet6":
                                if (typeof options.ipv6 === 'undefined' ) {
                                    options.ipv6 = [];
                                }
                                var ip6 = {

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

                            case "inet":

                                if (typeof options.ipv4 === 'undefined' ) {
                                    options.ipv4 = [];
                                }

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

            return Promise.try(function() {
                assert.string(identifier, 'invalid identifier specified: ' + identifier);
                return waterline.nodes.needByIdentifier(identifier);
            })
            .then(function(node) {

• Read up
  Read up

Function _render has 59 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    function _render(viewName, req, res) {
        var options;

        return Promise.try(function() {
            assert.optionalString(viewName);

Identical blocks of code found in 2 locations. Consider refactoring.

Open

        return fs.readdirAsync(fromRoot)
        .filter(function(entry) {
            return fs.statSync(fromRoot + '/' + entry).isFile();
        })
        .map(function(entry) {

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

    var config = _.defaults(
        req.swagger.params.name.value ? { name: req.swagger.params.name.value } : {},
        req.swagger.params.body.value || {}
    );

• Read up
  Read up