Sign upLogin

RackHD/on-wss

View on GitHub
Star

Showing 17 of 17 total issues

Function webSocketServiceFactory has 188 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function webSocketServiceFactory(
    Logger,
    serviceConfiguration,
    uuid,
    WebSocketError,
Severity: Major
Found in lib/ws-service.js - About 7 hrs to fix

    Function webSocketServiceFactory has a Cognitive Complexity of 40 (exceeds 5 allowed). Consider refactoring.
    Open

    function webSocketServiceFactory(
    Logger,
    serviceConfiguration,
    uuid,
    WebSocketError,
    Severity: Minor
    Found in lib/ws-service.js - About 6 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function webSocketResourcesFactory has 96 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    function webSocketResourcesFactory(Constants, Logger, collections, messenger) {
    var logger = Logger.initialize(webSocketResourcesFactory);

    return {
        catalogs: mongoCollectionResource(collections, 'catalogs', 'catalogs'),
    Severity: Major
    Found in lib/ws-resources.js - About 3 hrs to fix

      Function prepareGrunt has 92 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      function prepareGrunt(grunt) {
    var allFiles = [
        'package.json',
        'Gruntfile.js',
        'lib/**/*.js',
      Severity: Major
      Found in Gruntfile.js - About 3 hrs to fix

        Function onWssContextFactory has 54 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        function onWssContextFactory() {
    var core = onCore(),
        helper = core.helper,
        di = core.di;
        Severity: Major
        Found in index.js - About 2 hrs to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                      query: function (msg, wsConn) {
                return collections[name].find(msg.params).then(
                    function (items) { wsConn.sendList(resource, items); },
                    function (err) { wsConn.sendError(err, resource); });
            },
          Severity: Major
          Found in lib/ws-resources.js and 1 other location - About 2 hrs to fix
          lib/ws-resources.js on lines 92..96

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 76.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                      get: function (msg, wsConn) {
                return collections[name].findOne(msg.params).then(
                    function (data) { wsConn.sendItem(resource, data); },
                    function (err) { wsConn.sendError(err, resource); });
            },
          Severity: Major
          Found in lib/ws-resources.js and 1 other location - About 2 hrs to fix
          lib/ws-resources.js on lines 80..84

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 76.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Function _handleConnection has 50 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

                  _handleConnection(wsConn) {
            wsConn.id = uuid('v4');
            this.sessions[wsConn.id] = wsConn;
            logger.debug('Client: %s connected to WebSocketServer.'.format(wsConn.id));
            wsConn.addWatcher = (params, watcher) => {
          Severity: Minor
          Found in lib/ws-service.js - About 2 hrs to fix

            Function mongoCollectionResource has 48 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                function mongoCollectionResource(collections, name, resource) {
        return {
            query: function (msg, wsConn) {
                return collections[name].find(msg.params).then(
                    function (items) { wsConn.sendList(resource, items); },
            Severity: Minor
            Found in lib/ws-resources.js - About 1 hr to fix

              Function constructor has 35 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                      constructor() {
            this.handlers = this._defaultMessageHandlers(),
            this.resources = webSocketResources;
            this.sessions = {};
            var app = express();
              Severity: Minor
              Found in lib/ws-service.js - About 1 hr to fix

                Function run has 29 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                        run: function () {
            var logger = this.logger,
                messenger = this.messenger,
                waterline = this.waterline,
                wss = this.wss;
                Severity: Minor
                Found in index.js - About 1 hr to fix

                  Identical blocks of code found in 2 locations. Consider refactoring.
                  Open

                                  msg.params.exchange = Constants.Protocol.Exchanges.Waterline.Name,
                msg.params.routingKey = collections[name].identity + '.#';
                  Severity: Major
                  Found in lib/ws-resources.js and 1 other location - About 1 hr to fix
                  lib/ws-resources.js on lines 100..101

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 58.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Identical blocks of code found in 2 locations. Consider refactoring.
                  Open

                                  msg.params.exchange = Constants.Protocol.Exchanges.Waterline.Name,
                msg.params.routingKey = collections[name].identity + '.#';
                  Severity: Major
                  Found in lib/ws-resources.js and 1 other location - About 1 hr to fix
                  lib/ws-resources.js on lines 131..132

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 58.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Function start has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                          start(callback) {
            try {
                logger.info('Creating WebSocketServer, and initializing WebSocketService...');
                this.webSocketServer = new WebSocketServer(this.wssOptions);
                this.webSocketServer.on('connection', this._handleConnection.bind(this));
                  Severity: Minor
                  Found in lib/ws-service.js - About 1 hr to fix

                    Function webSocketServiceFactory has 6 arguments (exceeds 4 allowed). Consider refactoring.
                    Open

                        Logger,
    serviceConfiguration,
    uuid,
    WebSocketError,
    webSocketResources,
                    Severity: Minor
                    Found in lib/ws-service.js - About 45 mins to fix

                      Similar blocks of code found in 2 locations. Consider refactoring.
                      Open

                                  wsConn.sendRemove = (resource, id, data) => wsConn.sendObject({
              handler: 'remove',
              resource: resource,
              id: id,
              data: data
                      Severity: Minor
                      Found in lib/ws-service.js and 1 other location - About 35 mins to fix
                      lib/ws-service.js on lines 186..191

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 46.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Similar blocks of code found in 2 locations. Consider refactoring.
                      Open

                                  wsConn.sendItem = (resource, id, data) => wsConn.sendObject({
              handler: 'item',
              resource: resource,
              id: id,
              data: data
                      Severity: Minor
                      Found in lib/ws-service.js and 1 other location - About 35 mins to fix
                      lib/ws-service.js on lines 198..203

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 46.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Severity
                      Category
                      Status
                      Source
                      Language