Sign upLogin

RebelCode/rcmod-eddbk-admin-emails

View on GitHub
Star
src/Module/BookingsEmailTagTemplate.php

Summary

Maintainability
A
2 hrs
Test Coverage

Method _renderBooking has 31 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    protected function _renderBooking($booking)
    {
        $serviceId = $booking->getState()->get('service_id');

        // Create date time helper instance for the booking start time
Severity: Minor
Found in src/Module/BookingsEmailTagTemplate.php - About 1 hr to fix

    Method __construct has 7 arguments (exceeds 4 allowed). Consider refactoring.
    Open

            TemplateInterface $layoutTemplate,
        BookingFactoryInterface $bookingFactory,
        GetCapableManagerInterface $servicesManager,
        GetCapableManagerInterface $resourcesManager,
        CacheContainerInterface $serviceCache,
    Severity: Major
    Found in src/Module/BookingsEmailTagTemplate.php - About 50 mins to fix

      Avoid using static access to class '\Carbon\Carbon' in method '_renderBooking'.
      Open

              $startDt = Carbon::createFromTimestampUTC($startTs);
      Severity: Minor
      Found in src/Module/BookingsEmailTagTemplate.php by phpmd

      StaticAccess

      Since: 1.4.0

      Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

      Example

      class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

      Source https://phpmd.org/rules/cleancode.html#staticaccess

      Avoid excessively long variable names like $bookingDateTimeFormat. Keep variable name length under 20.
      Open

              $bookingDateTimeFormat
      Severity: Minor
      Found in src/Module/BookingsEmailTagTemplate.php by phpmd

      LongVariable

      Since: 0.2

      Detects when a field, formal or local variable is declared with a long name.

      Example

      class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

      Source https://phpmd.org/rules/naming.html#longvariable

      Avoid excessively long variable names like $bookingDateTimeFormat. Keep variable name length under 20.
      Open

          protected $bookingDateTimeFormat;
      Severity: Minor
      Found in src/Module/BookingsEmailTagTemplate.php by phpmd

      LongVariable

      Since: 0.2

      Detects when a field, formal or local variable is declared with a long name.

      Example

      class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

      Source https://phpmd.org/rules/naming.html#longvariable

      There are no issues that match your filters.

      Category
      Status