Sign upLogin

RebelCode/rcmod-eddbk-cart

View on GitHub
Star

Showing 39 of 39 total issues

Method __invoke has 47 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function __invoke()
    {
        // Get the event instance and ensure it implements the interface
        $event = func_get_arg(0);
        if (!($event instanceof EventInterface)) {
Severity: Minor
Found in src/Module/SubmitBookingOnPaymentHandler.php - About 1 hr to fix

    Method __invoke has 36 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function __invoke()
    {
        $items = $this->eddCart->get_contents();

        // Get the cart item data keys from the cart item config
    Severity: Minor
    Found in src/Module/ValidateCartBookingHandler.php - About 1 hr to fix

      Function __invoke has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
      Open

          public function __invoke()
    {
        // Get the event instance and ensure it implements the interface
        $event = func_get_arg(0);
        if (!($event instanceof EventInterface)) {
      Severity: Minor
      Found in src/Module/SubmitBookingOnPaymentHandler.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method __construct has 11 arguments (exceeds 4 allowed). Consider refactoring.
      Open

              TemplateInterface $bookingTableTemplate,
        TemplateInterface $bookingRowTemplate,
        SelectCapableInterface $bookingsSelectRm,
        BookingFactoryInterface $bookingFactory,
        GetCapableManagerInterface $servicesManager,
      Severity: Major
      Found in src/Module/RenderConfirmationBookingsHandler.php - About 1 hr to fix

        Avoid using short method names like GetBookingSessionTypeCapableTrait::__(). The configured minimum method name length is 3.
        Open

            abstract protected function __($string, $args = [], $context = null);
        Severity: Minor
        Found in src/Module/GetBookingSessionTypeCapableTrait.php by phpmd

        ShortMethodName

        Since: 0.2

        Detects when very short method names are used.

        Example

        class ShortMethod {
    public function a( $index ) { // Violation
    }
}

        Source https://phpmd.org/rules/naming.html#shortmethodname

        Avoid using short method names like GetBookingDisplayTimezoneCapableTrait::__(). The configured minimum method name length is 3.
        Open

            abstract protected function __($string, $args = [], $context = null);
        Severity: Minor
        Found in src/Module/GetBookingDisplayTimezoneCapableTrait.php by phpmd

        ShortMethodName

        Since: 0.2

        Detects when very short method names are used.

        Example

        class ShortMethod {
    public function a( $index ) { // Violation
    }
}

        Source https://phpmd.org/rules/naming.html#shortmethodname

        Method __construct has 10 arguments (exceeds 4 allowed). Consider refactoring.
        Open

                TemplateInterface $template,
        SelectCapableInterface $bookingsSelectRm,
        BookingFactoryInterface $bookingFactory,
        GetCapableManagerInterface $servicesManager,
        GetCapableManagerInterface $resourcesManager,
        Severity: Major
        Found in src/Module/RenderCartBookingInfoHandler.php - About 1 hr to fix

          Function __invoke has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
          Open

              public function __invoke()
    {
        $items = $this->eddCart->get_contents();

        // Get the cart item data keys from the cart item config
          Severity: Minor
          Found in src/Module/ValidateCartBookingHandler.php - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method __invoke has 31 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function __invoke()
    {
        $event = func_get_arg(0);

        if (!($event instanceof EventInterface)) {
          Severity: Minor
          Found in src/Module/FilterCartItemPriceHandler.php - About 1 hr to fix

            Method _getBookingSessionType has 31 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                protected function _getBookingSessionType($booking)
    {
        $bookingDuration  = $booking->getDuration();
        $bookingResources = $this->_normalizeArray($booking->getResourceIds());
            Severity: Minor
            Found in src/Module/GetBookingSessionTypeCapableTrait.php - About 1 hr to fix

              Method _addToCart has 31 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  protected function _addToCart($booking)
    {
        $state = $booking->getState();

        $bookingId  = $state->get('id');
              Severity: Minor
              Found in src/Module/AddBookingToCartHandler.php - About 1 hr to fix

                Method _renderBookingRow has 30 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    protected function _renderBookingRow(BookingInterface $booking)
    {
        $bookingData = $booking->getState();

        $timezone = $this->_getDisplayTimezone($bookingData);
                Severity: Minor
                Found in src/Module/RenderConfirmationBookingsHandler.php - About 1 hr to fix

                  Method evaluate has 30 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      public function evaluate(ValueAwareInterface $ctx = null)
    {
        $booking = $ctx->getValue();

        if (!($booking instanceof StateAwareInterface) || !($booking instanceof BookingInterface)) {
                  Severity: Minor
                  Found in src/BookingPriceEvaluator.php - About 1 hr to fix

                    Method _renderBookingInfo has 30 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                        protected function _renderBookingInfo($bookingData)
    {
        $booking = $this->bookingFactory->make([
            BookingFactoryInterface::K_DATA => $bookingData,
        ]);
                    Severity: Minor
                    Found in src/Module/RenderCartBookingInfoHandler.php - About 1 hr to fix

                      Method __construct has 7 arguments (exceeds 4 allowed). Consider refactoring.
                      Open

                              $key,
        $dependencies,
        $configFactory,
        $containerFactory,
        $compContainerFactory,
                      Severity: Major
                      Found in src/Module/EddBkCartModule.php - About 50 mins to fix

                        Avoid variables with short names like $b. Configured minimum length is 3.
                        Open

                                $b = $this->exprBuilder;
                        Severity: Minor
                        Found in src/Module/RenderCartBookingInfoHandler.php by phpmd

                        ShortVariable

                        Since: 0.2

                        Detects when a field, local, or parameter has a very short name.

                        Example

                        class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

                        Source https://phpmd.org/rules/naming.html#shortvariable

                        Avoid variables with short names like $c. Configured minimum length is 3.
                        Open

                            public function run(ContainerInterface $c = null)
                        Severity: Minor
                        Found in src/Module/EddBkCartModule.php by phpmd

                        ShortVariable

                        Since: 0.2

                        Detects when a field, local, or parameter has a very short name.

                        Example

                        class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

                        Source https://phpmd.org/rules/naming.html#shortvariable

                        Avoid variables with short names like $b. Configured minimum length is 3.
                        Open

                                $b = $this->exprBuilder;
                        Severity: Minor
                        Found in src/Module/RenderConfirmationBookingsHandler.php by phpmd

                        ShortVariable

                        Since: 0.2

                        Detects when a field, local, or parameter has a very short name.

                        Example

                        class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

                        Source https://phpmd.org/rules/naming.html#shortvariable

                        Avoid variables with short names like $b. Configured minimum length is 3.
                        Open

                                $b = $this->exprBuilder;
                        Severity: Minor
                        Found in src/Module/SubmitBookingOnPaymentHandler.php by phpmd

                        ShortVariable

                        Since: 0.2

                        Detects when a field, local, or parameter has a very short name.

                        Example

                        class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

                        Source https://phpmd.org/rules/naming.html#shortvariable

                        Avoid variables with short names like $b. Configured minimum length is 3.
                        Open

                                $b = $this->exprBuilder;
                        Severity: Minor
                        Found in src/Module/ValidateCartBookingHandler.php by phpmd

                        ShortVariable

                        Since: 0.2

                        Detects when a field, local, or parameter has a very short name.

                        Example

                        class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

                        Source https://phpmd.org/rules/naming.html#shortvariable

                        Severity
                        Category
                        Status
                        Source
                        Language