Sign upLogin

RebelCode/rcmod-eddbk-cart

View on GitHub
Star

Showing 39 of 39 total issues

Avoid variables with short names like $b. Configured minimum length is 3.
Open

        $b = $this->exprBuilder;
Severity: Minor
Found in src/Module/FilterCartItemPriceHandler.php by phpmd

ShortVariable

Since: 0.2

Detects when a field, local, or parameter has a very short name.

Example

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Source https://phpmd.org/rules/naming.html#shortvariable

Avoid variables with short names like $c. Configured minimum length is 3.
Open

        $c = $b->eq($b->var('id'), $b->lit($bookingId));
Severity: Minor
Found in src/Module/RemoveBookingFromCartHandler.php by phpmd

ShortVariable

Since: 0.2

Detects when a field, local, or parameter has a very short name.

Example

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Source https://phpmd.org/rules/naming.html#shortvariable

Avoid variables with short names like $b. Configured minimum length is 3.
Open

        $b = $this->exprBuilder;
Severity: Minor
Found in src/Module/RemoveBookingFromCartHandler.php by phpmd

ShortVariable

Since: 0.2

Detects when a field, local, or parameter has a very short name.

Example

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Source https://phpmd.org/rules/naming.html#shortvariable

Method __construct has 6 arguments (exceeds 4 allowed). Consider refactoring.
Open

        SelectCapableInterface $bookingsSelectRm,
        StateAwareFactoryInterface $stateAwareFactory,
        EvaluableInterface $priceEvaluator,
        FactoryInterface $valueAwareFactory,
        $exprBuilder,
Severity: Minor
Found in src/Module/FilterCartItemPriceHandler.php - About 45 mins to fix

    Function _getBookingSessionType has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

        protected function _getBookingSessionType($booking)
    {
        $bookingDuration  = $booking->getDuration();
        $bookingResources = $this->_normalizeArray($booking->getResourceIds());
    Severity: Minor
    Found in src/Module/GetBookingSessionTypeCapableTrait.php - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method __construct has 6 arguments (exceeds 4 allowed). Consider refactoring.
    Open

            EDD_Cart $eddCart,
        ValidatorInterface $validator,
        BookingFactoryInterface $bookingFactory,
        SelectCapableInterface $bookingsSelectRm,
        $exprBuilder,
    Severity: Minor
    Found in src/Module/ValidateCartBookingHandler.php - About 45 mins to fix

      Method __construct has 6 arguments (exceeds 4 allowed). Consider refactoring.
      Open

              TransitionerInterface $transitioner,
        StateAwareFactoryInterface $stateAwareFactory,
        SelectCapableInterface $bookingsSelectRm,
        UpdateCapableInterface $bookingsUpdateRm,
        $exprBuilder,
      Severity: Minor
      Found in src/Module/SubmitBookingOnPaymentHandler.php - About 45 mins to fix

        Method __construct has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

                EDD_Cart $eddCart,
        SelectCapableInterface $bookingsSelectRm,
        DeleteCapableInterface $bookingsDeleteRm,
        $exprBuilder,
        $cartItemConfig
        Severity: Minor
        Found in src/Module/RemoveBookingFromCartHandler.php - About 35 mins to fix

          Function evaluate has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

              public function evaluate(ValueAwareInterface $ctx = null)
    {
        $booking = $ctx->getValue();

        if (!($booking instanceof StateAwareInterface) || !($booking instanceof BookingInterface)) {
          Severity: Minor
          Found in src/BookingPriceEvaluator.php - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          The method _getWordPressOption has a boolean flag argument $default, which is a certain sign of a Single Responsibility Principle violation.
          Open

              protected function _getWordPressOption($key, $default = false)
          Severity: Minor
          Found in src/Module/GetBookingDisplayTimezoneCapableTrait.php by phpmd

          BooleanArgumentFlag

          Since: 1.4.0

          A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

          Example

          class Foo {
    public function bar($flag = true) {
    }
}

          Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

          Avoid using static access to class '\Carbon\Carbon' in method '_renderBookingInfo'.
          Open

                  $startDt = Carbon::createFromTimestampUTC($startTs);
          Severity: Minor
          Found in src/Module/RenderCartBookingInfoHandler.php by phpmd

          StaticAccess

          Since: 1.4.0

          Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

          Example

          class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

          Source https://phpmd.org/rules/cleancode.html#staticaccess

          The method __construct has 11 parameters. Consider reducing the number of parameters to less than 10.
          Open

              public function __construct(
        TemplateInterface $bookingTableTemplate,
        TemplateInterface $bookingRowTemplate,
        SelectCapableInterface $bookingsSelectRm,
        BookingFactoryInterface $bookingFactory,
          Severity: Minor
          Found in src/Module/RenderConfirmationBookingsHandler.php by phpmd

          Avoid using static access to class '\Carbon\Carbon' in method '_renderBookingRow'.
          Open

                  $endDt   = Carbon::createFromTimestampUTC($endTs);
          Severity: Minor
          Found in src/Module/RenderConfirmationBookingsHandler.php by phpmd

          StaticAccess

          Since: 1.4.0

          Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

          Example

          class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

          Source https://phpmd.org/rules/cleancode.html#staticaccess

          Avoid using static access to class '\Carbon\Carbon' in method '_renderBookingInfo'.
          Open

                  $endDt   = Carbon::createFromTimestampUTC($endTs);
          Severity: Minor
          Found in src/Module/RenderCartBookingInfoHandler.php by phpmd

          StaticAccess

          Since: 1.4.0

          Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

          Example

          class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

          Source https://phpmd.org/rules/cleancode.html#staticaccess

          Avoid using static access to class '\Carbon\Carbon' in method '_renderBookingRow'.
          Open

                  $startDt = Carbon::createFromTimestampUTC($startTs);
          Severity: Minor
          Found in src/Module/RenderConfirmationBookingsHandler.php by phpmd

          StaticAccess

          Since: 1.4.0

          Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

          Example

          class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

          Source https://phpmd.org/rules/cleancode.html#staticaccess

          Avoid unused parameters such as '$exception'.
          Open

              protected function _getBookingValidationErrors(ValidationFailedExceptionInterface $exception)
          Severity: Minor
          Found in src/Module/ValidateCartBookingHandler.php by phpmd

          UnusedFormalParameter

          Since: 0.2

          Avoid passing parameters to methods or constructors and then not using those parameters.

          Example

          class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

          Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

          The method __construct has 10 parameters. Consider reducing the number of parameters to less than 10.
          Open

              public function __construct(
        TemplateInterface $template,
        SelectCapableInterface $bookingsSelectRm,
        BookingFactoryInterface $bookingFactory,
        GetCapableManagerInterface $servicesManager,
          Severity: Minor
          Found in src/Module/RenderCartBookingInfoHandler.php by phpmd

          The method __ is not named in camelCase.
          Open

              abstract protected function __($string, $args = [], $context = null);
          Severity: Minor
          Found in src/Module/GetBookingSessionTypeCapableTrait.php by phpmd

          CamelCaseMethodName

          Since: 0.2

          It is considered best practice to use the camelCase notation to name methods.

          Example

          class ClassName {
    public function get_name() {
    }
}

          Source

          The method __ is not named in camelCase.
          Open

              abstract protected function __($string, $args = [], $context = null);
          Severity: Minor
          Found in src/Module/GetBookingDisplayTimezoneCapableTrait.php by phpmd

          CamelCaseMethodName

          Since: 0.2

          It is considered best practice to use the camelCase notation to name methods.

          Example

          class ClassName {
    public function get_name() {
    }
}

          Source

          Severity
          Category
          Status
          Source
          Language