Sign upLogin

RebelCode/rcmod-eddbk-cart

View on GitHub
Star
src/Module/FilterCartItemPriceHandler.php

Summary

Maintainability
A
2 hrs
Test Coverage

Method __invoke has 31 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function __invoke()
    {
        $event = func_get_arg(0);

        if (!($event instanceof EventInterface)) {
Severity: Minor
Found in src/Module/FilterCartItemPriceHandler.php - About 1 hr to fix

    Method __construct has 6 arguments (exceeds 4 allowed). Consider refactoring.
    Open

            SelectCapableInterface $bookingsSelectRm,
        StateAwareFactoryInterface $stateAwareFactory,
        EvaluableInterface $priceEvaluator,
        FactoryInterface $valueAwareFactory,
        $exprBuilder,
    Severity: Minor
    Found in src/Module/FilterCartItemPriceHandler.php - About 45 mins to fix

      Avoid variables with short names like $b. Configured minimum length is 3.
      Open

              $b = $this->exprBuilder;
      Severity: Minor
      Found in src/Module/FilterCartItemPriceHandler.php by phpmd

      ShortVariable

      Since: 0.2

      Detects when a field, local, or parameter has a very short name.

      Example

      class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

      Source https://phpmd.org/rules/naming.html#shortvariable

      There are no issues that match your filters.

      Category
      Status