src/Module/RemoveBookingFromCartHandler.php
Method __construct
has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
Open
EDD_Cart $eddCart,
SelectCapableInterface $bookingsSelectRm,
DeleteCapableInterface $bookingsDeleteRm,
$exprBuilder,
$cartItemConfig
Avoid variables with short names like $c. Configured minimum length is 3. Open
Open
$c = $b->eq($b->var('id'), $b->lit($bookingId));
- Read upRead up
- Exclude checks
ShortVariable
Since: 0.2
Detects when a field, local, or parameter has a very short name.
Example
class Something {
private $q = 15; // VIOLATION - Field
public static function main( array $as ) { // VIOLATION - Formal
$r = 20 + $this->q; // VIOLATION - Local
for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
$r += $this->q;
}
}
}
Source https://phpmd.org/rules/naming.html#shortvariable
Avoid variables with short names like $b. Configured minimum length is 3. Open
Open
$b = $this->exprBuilder;
- Read upRead up
- Exclude checks
ShortVariable
Since: 0.2
Detects when a field, local, or parameter has a very short name.
Example
class Something {
private $q = 15; // VIOLATION - Field
public static function main( array $as ) { // VIOLATION - Formal
$r = 20 + $this->q; // VIOLATION - Local
for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
$r += $this->q;
}
}
}