Sign upLogin

RebelCode/rcmod-eddbk-cart

View on GitHub
Star
src/Module/RenderCartBookingInfoHandler.php

Summary

Maintainability
A
2 hrs
Test Coverage

Method __construct has 10 arguments (exceeds 4 allowed). Consider refactoring.
Open

        TemplateInterface $template,
        SelectCapableInterface $bookingsSelectRm,
        BookingFactoryInterface $bookingFactory,
        GetCapableManagerInterface $servicesManager,
        GetCapableManagerInterface $resourcesManager,
Severity: Major
Found in src/Module/RenderCartBookingInfoHandler.php - About 1 hr to fix

    Method _renderBookingInfo has 30 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        protected function _renderBookingInfo($bookingData)
    {
        $booking = $this->bookingFactory->make([
            BookingFactoryInterface::K_DATA => $bookingData,
        ]);
    Severity: Minor
    Found in src/Module/RenderCartBookingInfoHandler.php - About 1 hr to fix

      The method __construct has 10 parameters. Consider reducing the number of parameters to less than 10.
      Open

          public function __construct(
        TemplateInterface $template,
        SelectCapableInterface $bookingsSelectRm,
        BookingFactoryInterface $bookingFactory,
        GetCapableManagerInterface $servicesManager,
      Severity: Minor
      Found in src/Module/RenderCartBookingInfoHandler.php by phpmd

      Avoid using static access to class '\Carbon\Carbon' in method '_renderBookingInfo'.
      Open

              $startDt = Carbon::createFromTimestampUTC($startTs);
      Severity: Minor
      Found in src/Module/RenderCartBookingInfoHandler.php by phpmd

      StaticAccess

      Since: 1.4.0

      Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

      Example

      class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

      Source https://phpmd.org/rules/cleancode.html#staticaccess

      Avoid using static access to class '\Carbon\Carbon' in method '_renderBookingInfo'.
      Open

              $endDt   = Carbon::createFromTimestampUTC($endTs);
      Severity: Minor
      Found in src/Module/RenderCartBookingInfoHandler.php by phpmd

      StaticAccess

      Since: 1.4.0

      Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

      Example

      class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

      Source https://phpmd.org/rules/cleancode.html#staticaccess

      Avoid variables with short names like $b. Configured minimum length is 3.
      Open

              $b = $this->exprBuilder;
      Severity: Minor
      Found in src/Module/RenderCartBookingInfoHandler.php by phpmd

      ShortVariable

      Since: 0.2

      Detects when a field, local, or parameter has a very short name.

      Example

      class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

      Source https://phpmd.org/rules/naming.html#shortvariable

      There are no issues that match your filters.

      Category
      Status