Sign upLogin

RebelCode/rcmod-eddbk-cart

View on GitHub
Star
src/Module/SubmitBookingOnPaymentHandler.php

Summary

Maintainability
B
4 hrs
Test Coverage

Method __invoke has 47 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function __invoke()
    {
        // Get the event instance and ensure it implements the interface
        $event = func_get_arg(0);
        if (!($event instanceof EventInterface)) {
Severity: Minor
Found in src/Module/SubmitBookingOnPaymentHandler.php - About 1 hr to fix

    Function __invoke has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
    Open

        public function __invoke()
    {
        // Get the event instance and ensure it implements the interface
        $event = func_get_arg(0);
        if (!($event instanceof EventInterface)) {
    Severity: Minor
    Found in src/Module/SubmitBookingOnPaymentHandler.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method __construct has 6 arguments (exceeds 4 allowed). Consider refactoring.
    Open

            TransitionerInterface $transitioner,
        StateAwareFactoryInterface $stateAwareFactory,
        SelectCapableInterface $bookingsSelectRm,
        UpdateCapableInterface $bookingsUpdateRm,
        $exprBuilder,
    Severity: Minor
    Found in src/Module/SubmitBookingOnPaymentHandler.php - About 45 mins to fix

      Avoid variables with short names like $b. Configured minimum length is 3.
      Open

              $b = $this->exprBuilder;
      Severity: Minor
      Found in src/Module/SubmitBookingOnPaymentHandler.php by phpmd

      ShortVariable

      Since: 0.2

      Detects when a field, local, or parameter has a very short name.

      Example

      class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

      Source https://phpmd.org/rules/naming.html#shortvariable

      There are no issues that match your filters.

      Category
      Status