Sign upLogin

RebelCode/sql-cqrs-resource-models-abstract

View on GitHub
Star
src/BuildSelectSqlCapableTrait.php

Summary

Maintainability
A
2 hrs
Test Coverage

Method _buildSelectSql has 35 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    protected function _buildSelectSql(
        $columns,
        $tables,
        $joins = [],
        LogicalExpressionInterface $where = null,
Severity: Minor
Found in src/BuildSelectSqlCapableTrait.php - About 1 hr to fix

    Method _buildSelectSql has 9 arguments (exceeds 4 allowed). Consider refactoring.
    Open

            $columns,
        $tables,
        $joins = [],
        LogicalExpressionInterface $where = null,
        $ordering = null,
    Severity: Major
    Found in src/BuildSelectSqlCapableTrait.php - About 1 hr to fix

      Avoid using short method names like BuildSelectSqlCapableTrait::__(). The configured minimum method name length is 3.
      Open

          abstract protected function __($string, $args = [], $context = null);
      Severity: Minor
      Found in src/BuildSelectSqlCapableTrait.php by phpmd

      ShortMethodName

      Since: 0.2

      Detects when very short method names are used.

      Example

      class ShortMethod {
    public function a( $index ) { // Violation
    }
}

      Source https://phpmd.org/rules/naming.html#shortmethodname

      The method __ is not named in camelCase.
      Open

          abstract protected function __($string, $args = [], $context = null);
      Severity: Minor
      Found in src/BuildSelectSqlCapableTrait.php by phpmd

      CamelCaseMethodName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name methods.

      Example

      class ClassName {
    public function get_name() {
    }
}

      Source

      There are no issues that match your filters.

      Category
      Status