Reconmap/web-client

View on GitHub

Showing 450 of 450 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

                <ModalHeader>
                    <HStack>
                        <TargetIcon style={{ width: "24px" }} />{" "}
                        <h4>New report version details</h4>
                    </HStack>
Severity: Major
Found in src/components/reports/ModalDialog.jsx and 1 other location - About 1 hr to fix
src/components/target/ModalDialog.jsx on lines 52..57

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 62.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Consider simplifying this complex logical expression.
Open

            if ((key === 'LC') || (key === 'LI') || (key === 'LAV') || (key === 'LAC')
                || (key === 'FD') || (key === 'RD') || (key === 'NC') || (key === 'PV')) {
                sum += parseInt(value);
            }
Severity: Critical
Found in src/components/vulnerabilities/OwaspRR.jsx - About 1 hr to fix

Consider simplifying this complex logical expression.
Open

            if ((key === 'SL') || (key === 'M') || (key === 'O') || (key === 'S')
                || (key === 'ED') || (key === 'EE') || (key === 'A') || (key === 'ID')) {
                sum += parseInt(value);
            }
Severity: Critical
Found in src/components/vulnerabilities/OwaspRR.jsx - About 1 hr to fix

Function ProjectEdit has 33 lines of code (exceeds 25 allowed). Consider refactoring.
Open

const ProjectEdit = () => {
    const navigate = useNavigate();
    const { projectId } = useParams();
    const [serverProject] = useFetch(`/projects/${projectId}`);
    const [clientProject, setClientProject] = useState(null);
Severity: Minor
Found in src/components/projects/Edit.jsx - About 1 hr to fix

Function SearchBox has 33 lines of code (exceeds 25 allowed). Consider refactoring.
Open

const SearchBox = () => {
    const navigate = useNavigate();
    const inputRef = createRef();

    const onKeyDownListener = useCallback(
Severity: Minor
Found in src/components/search/Box.jsx - About 1 hr to fix

Function HeaderUserMenu has 32 lines of code (exceeds 25 allowed). Consider refactoring.
Open

const HeaderUserMenu = () => {
    const { user, logout } = useContext(AuthContext);

    return <Menu closeOnBlur closeOnSelect>
        <MenuButton>
Severity: Minor
Found in src/components/ui/HeaderUserMenu.jsx - About 1 hr to fix

Function reloadVulnerabilities has 32 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    const reloadVulnerabilities = useCallback(() => {
        setTableModel((tableModel) => ({
            ...tableModel,
            vulnerabilities: null,
        }));
Severity: Minor
Found in src/components/vulnerabilities/List.jsx - About 1 hr to fix

Function VulnerabilitiesTable has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

const VulnerabilitiesTable = ({
    tableModel,
    tableModelSetter: setTableModel,
    reloadCallback,
    showSelection = true,
Severity: Minor
Found in src/components/vulnerabilities/VulnerabilitiesTable.jsx - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function ProjectForm has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

const ProjectForm = ({
    isEdit = false,
    project,
    projectSetter: setProject,
    onFormSubmit,
Severity: Minor
Found in src/components/projects/Form.jsx - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function EditClientPage has 31 lines of code (exceeds 25 allowed). Consider refactoring.
Open

const EditClientPage = () => {
    const navigate = useNavigate();
    const { clientId } = useParams();

    const [serverClient] = useFetch(`/clients/${clientId}`);
Severity: Minor
Found in src/components/clients/Edit.jsx - About 1 hr to fix

Function EditCommandPage has 31 lines of code (exceeds 25 allowed). Consider refactoring.
Open

const EditCommandPage = () => {
    const navigate = useNavigate();
    const { commandId } = useParams();

    const [serverCommand] = useFetch(`/commands/${commandId}`);
Severity: Minor
Found in src/components/commands/Edit.jsx - About 1 hr to fix

Function registerValidSW has 31 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function registerValidSW(swUrl, config) {
    navigator.serviceWorker
        .register(swUrl)
        .then(registration => {
            registration.onupdatefound = () => {
Severity: Minor
Found in src/serviceWorker.js - About 1 hr to fix

Function EditDocumentPage has 31 lines of code (exceeds 25 allowed). Consider refactoring.
Open

const EditDocumentPage = () => {
    const navigate = useNavigate();
    const { documentId } = useParams();

    const [serverDocument] = useFetch(`/documents/${documentId}`);
Severity: Minor
Found in src/components/documents/Edit.jsx - About 1 hr to fix

Function ProjectCreate has 29 lines of code (exceeds 25 allowed). Consider refactoring.
Open

const ProjectCreate = () => {
    const navigate = useNavigate();
    const query = useQuery();
    const isTemplate = 'true' === query.get('isTemplate');
    const [newProject, setNewProject] = useState({ ...Project, is_template: isTemplate });
Severity: Minor
Found in src/components/projects/Create.jsx - About 1 hr to fix

Function EditUserPage has 29 lines of code (exceeds 25 allowed). Consider refactoring.
Open

const EditUserPage = () => {
    const navigate = useNavigate();
    const { userId } = useParams();
    const [serverUser] = useFetch(`/users/${userId}`);
    const [clientUser, setClientUser] = useState(null);
Severity: Minor
Found in src/components/users/Edit.jsx - About 1 hr to fix

Identical blocks of code found in 2 locations. Consider refactoring.
Open

    const onFilterChange = ev => {
        setTableModel({ ...tableModel, filters: { ...tableModel.filters, [ev.target.name]: ev.target.value } });
    }
Severity: Major
Found in src/components/tasks/Filters.jsx and 1 other location - About 1 hr to fix
src/components/vulnerabilities/Filters.jsx on lines 15..23

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 58.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

    const onFilterChange = (ev) => {
        setTableModel({
            ...tableModel,
            filters: {
                ...tableModel.filters,
Severity: Major
Found in src/components/vulnerabilities/Filters.jsx and 1 other location - About 1 hr to fix
src/components/tasks/Filters.jsx on lines 12..14

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 58.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

                {project.archived === 1 && (
                    <dl>
                        <dt>Archived</dt>
                        <dd>
                            <RelativeDateFormatter date={project.archive_ts} />
Severity: Major
Found in src/components/projects/DetailsTab.jsx and 1 other location - About 1 hr to fix
src/components/tasks/Details.jsx on lines 275..284

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 58.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

                <label>
                    Username
                    <NativeInput
                        type="text"
                        name="username"
Severity: Major
Found in src/components/users/Form.jsx and 1 other location - About 1 hr to fix
src/components/vulnerabilities/Form.jsx on lines 226..236

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 58.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

                        <label>
                            Summary
                            <NativeInput
                                type="text"
                                name="summary"
Severity: Major
Found in src/components/vulnerabilities/Form.jsx and 1 other location - About 1 hr to fix
src/components/users/Form.jsx on lines 102..112

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 58.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Severity
Category
Status
Source
Language