Sign upLogin

Restream/redmine_elasticsearch

View on GitHub
Star
lib/redmine_elasticsearch/patches/search_controller_patch.rb

Summary

Maintainability
C
7 hrs
Test Coverage

Method perform_search has 60 lines of code (exceeds 25 allowed). Consider refactoring.
Open

      def perform_search(options = {})
        #todo: refactor this
        project_ids = options[:projects] ? [options[:projects]].flatten.compact.map(&:id) : nil

        common_must = []
Severity: Major
Found in lib/redmine_elasticsearch/patches/search_controller_patch.rb - About 2 hrs to fix

    Method index has 39 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

          def index
        get_variables_from_params

        # quick jump to an issue
        if issue = detect_issue_in_question(@question)
    Severity: Minor
    Found in lib/redmine_elasticsearch/patches/search_controller_patch.rb - About 1 hr to fix

      Method get_variables_from_params has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
      Open

            def get_variables_from_params
        @question = params[:q] || ''
        @question.strip!
        @all_words          = params[:all_words] ? params[:all_words].present? : true
        @titles_only        = params[:titles_only] ? params[:titles_only].present? : false
      Severity: Minor
      Found in lib/redmine_elasticsearch/patches/search_controller_patch.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method index has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
      Open

            def index
        get_variables_from_params

        # quick jump to an issue
        if issue = detect_issue_in_question(@question)
      Severity: Minor
      Found in lib/redmine_elasticsearch/patches/search_controller_patch.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method perform_search has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

            def perform_search(options = {})
        #todo: refactor this
        project_ids = options[:projects] ? [options[:projects]].flatten.compact.map(&:id) : nil

        common_must = []
      Severity: Minor
      Found in lib/redmine_elasticsearch/patches/search_controller_patch.rb - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status