RocketChat/Rocket.Chat.Ops

View on GitHub

Showing 611 of 611 total issues

Function add has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

    ProjectMilestones.prototype.add = function(projectId, title, description, due_date, fn) {
Severity: Minor
Found in hubots/hubot-gitsy/src/gitlab/lib/Models/ProjectMilestones.js - About 35 mins to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

          results.push(console.log("#" + user.id + ": " + user.email + ", " + user.name + ", " + user.created_at));
    Severity: Minor
    Found in hubots/hubot-gitsy/src/gitlab/examples/list-users.js and 1 other location - About 30 mins to fix
    hubots/hubot-gitsy/src/gitlab/examples/list-projects.js on lines 20..20

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 45.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

          results.push(console.log("#" + project.id + ": " + project.name + ", path: " + project.path + ", default_branch: " + project.default_branch + ", private: " + project["private"] + ", owner: " + project.owner.name + " (" + project.owner.email + "), date: " + project.created_at));
    Severity: Minor
    Found in hubots/hubot-gitsy/src/gitlab/examples/list-projects.js and 1 other location - About 30 mins to fix
    hubots/hubot-gitsy/src/gitlab/examples/list-users.js on lines 20..20

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 45.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Line contains inconsistent indentation
    Open

        RocketChat.settings.addGroup 'Chatops'

    Line contains inconsistent indentation
    Open

        gitlabURL = process.env['GITLAB_URL']

    Line contains inconsistent indentation
    Open

                    icon = ""

    Line contains inconsistent indentation
    Open

            gitlab.projects.all  (projects) =>

    Line contains inconsistent indentation
    Open

                            output = output + 'MORE ...\n'

    Line contains inconsistent indentation
    Open

            url = "https://api.github.com/repos/" + res.match[1] + "/issues?state=open"

    Line contains inconsistent indentation
    Open

            url = "https://api.github.com/repos/" + res.match[1] + "/issues?state=open"

    Line contains inconsistent indentation
    Open

            console.error("the environment variable GITLAB_URL must be set for hubot-gitsy to work properly")

    Line contains inconsistent indentation
    Open

            console.log "##{project.id}: #{project.name}, path: #{project.path}, default_branch: #{project.default_branch}, private: #{project.private}, owner: #{project.owner.name} (#{project.owner.email}), date: #{project.created_at}"

    Line contains inconsistent indentation
    Open

        url:     credentials.url

    Line contains inconsistent indentation
    Open

        RocketChat.callbacks.add 'enter-room', ->

    Line contains inconsistent indentation
    Open

                            break

    Line contains inconsistent indentation
    Open

        token:    credentials.token

    Line contains inconsistent indentation
    Open

        console.log ""

    Line contains inconsistent indentation
    Open

            gitlab.projects.all  (projects) =>

    Line contains inconsistent indentation
    Open

            output = '```\n'

    Line contains inconsistent indentation
    Open

                    id: 'chatops-button3'
    Severity
    Category
    Status
    Source
    Language