Sign upLogin

RocketChat/Rocket.Chat

View on GitHub
Star
apps/meteor/app/api/server/v1/voip/rooms.ts

Summary

Maintainability
C
1 day
Test Coverage

Function get has 43 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        async get() {
            const { token } = this.queryParams;
            let agentId: string | undefined = undefined;
            let direction: IVoipRoom['direction'] = 'inbound';
            let rid: string | undefined = undefined;
Severity: Minor
Found in apps/meteor/app/api/server/v1/voip/rooms.ts - About 1 hr to fix

    Function get has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
    Open

            async get() {
            const { token } = this.queryParams;
            let agentId: string | undefined = undefined;
            let direction: IVoipRoom['direction'] = 'inbound';
            let rid: string | undefined = undefined;
    Severity: Minor
    Found in apps/meteor/app/api/server/v1/voip/rooms.ts - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function get has 26 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            async get() {
            const { offset, count } = await getPaginationItems(this.queryParams);

            const { sort, fields } = await this.parseJsonQuery();
            const { agents, open, tags, queue, visitorId, direction, roomName } = this.queryParams;
    Severity: Minor
    Found in apps/meteor/app/api/server/v1/voip/rooms.ts - About 1 hr to fix

      Avoid too many return statements within this function.
      Open

                  return API.v1.success({ rid });
      Severity: Major
      Found in apps/meteor/app/api/server/v1/voip/rooms.ts - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

                        return API.v1.failure('invalid-room');
        Severity: Major
        Found in apps/meteor/app/api/server/v1/voip/rooms.ts - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                      return API.v1.success({ room, newRoom: false });
          Severity: Major
          Found in apps/meteor/app/api/server/v1/voip/rooms.ts - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                            return API.v1.success(
                    await LivechatVoip.getNewRoom(guest, agent, rid, direction, {
                        projection: API.v1.defaultFieldsToExclude,
                    }),
                );
            Severity: Major
            Found in apps/meteor/app/api/server/v1/voip/rooms.ts - About 30 mins to fix

              Similar blocks of code found in 4 locations. Consider refactoring.
              Open

                  if (date?.start && isNaN(Date.parse(date.start))) {
        throw new Error(`The "${property}.start" query parameter must be a valid date.`);
    }
              Severity: Major
              Found in apps/meteor/app/api/server/v1/voip/rooms.ts and 3 other locations - About 35 mins to fix
              apps/meteor/app/api/server/v1/voip/rooms.ts on lines 20..22
              apps/meteor/app/livechat/imports/server/rest/rooms.ts on lines 15..17
              apps/meteor/app/livechat/imports/server/rest/rooms.ts on lines 18..20

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 47.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 4 locations. Consider refactoring.
              Open

                  if (date?.end && isNaN(Date.parse(date.end))) {
        throw new Error(`The "${property}.end" query parameter must be a valid date.`);
    }
              Severity: Major
              Found in apps/meteor/app/api/server/v1/voip/rooms.ts and 3 other locations - About 35 mins to fix
              apps/meteor/app/api/server/v1/voip/rooms.ts on lines 17..19
              apps/meteor/app/livechat/imports/server/rest/rooms.ts on lines 15..17
              apps/meteor/app/livechat/imports/server/rest/rooms.ts on lines 18..20

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 47.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 3 locations. Consider refactoring.
              Open

                          const { agents, open, tags, queue, visitorId, direction, roomName } = this.queryParams;
              Severity: Minor
              Found in apps/meteor/app/api/server/v1/voip/rooms.ts and 2 other locations - About 35 mins to fix
              apps/meteor/app/livechat/imports/server/rest/rooms.ts on lines 33..33
              apps/meteor/app/livechat/imports/server/rest/triggers.ts on lines 34..34

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 47.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                          const hasAgentAccess =
                (await hasPermissionAsync(this.userId, 'view-l-room')) && agents?.includes(this.userId) && agents?.length === 1;
              Severity: Minor
              Found in apps/meteor/app/api/server/v1/voip/rooms.ts and 1 other location - About 35 mins to fix
              apps/meteor/app/livechat/imports/server/rest/rooms.ts on lines 40..41

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 46.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status