Sign upLogin

RocketChat/Rocket.Chat

View on GitHub
Star
apps/meteor/app/discussion/server/methods/createDiscussion.ts

Summary

Maintainability
B
6 hrs
Test Coverage

Function create has a Cognitive Complexity of 29 (exceeds 5 allowed). Consider refactoring.
Open

const create = async ({
    prid,
    pmid,
    t_name: discussionName,
    reply,
Severity: Minor
Found in apps/meteor/app/discussion/server/methods/createDiscussion.ts - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function createDiscussionMessage has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

    rid: IRoom['_id'],
    user: IUser,
    drid: IRoom['_id'],
    msg: IMessage['msg'],
    messageEmbedded?: MessageAttachmentDefault,
Severity: Minor
Found in apps/meteor/app/discussion/server/methods/createDiscussion.ts - About 35 mins to fix

    Similar blocks of code found in 10 locations. Consider refactoring.
    Open

    const create = async ({
    prid,
    pmid,
    t_name: discussionName,
    reply,
    Severity: Major
    Found in apps/meteor/app/discussion/server/methods/createDiscussion.ts and 9 other locations - About 40 mins to fix
    apps/meteor/client/components/message/content/UrlPreviews.tsx on lines 70..80
    apps/meteor/client/components/message/content/attachments/file/GenericFileAttachment.tsx on lines 26..100
    apps/meteor/client/components/message/content/urlPreviews/OEmbedPreviewContent.tsx on lines 16..49
    apps/meteor/client/views/account/profile/AccountProfileForm.tsx on lines 111..133
    apps/meteor/client/views/admin/users/AdminUserInfoActions.tsx on lines 28..146
    apps/meteor/client/views/room/composer/ComposerBoxPopupUser.tsx on lines 21..60
    apps/meteor/client/views/room/contextualBar/RoomMembers/RoomMembersItem.tsx on lines 30..60
    apps/meteor/client/views/teams/contextualBar/info/TeamsInfo.tsx on lines 43..210
    packages/livechat/src/components/uiKit/message/ButtonElement/index.tsx on lines 17..57

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 49.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

        return create({ prid, pmid, t_name: discussionName, reply, users, user, encrypted, topic });
    Severity: Major
    Found in apps/meteor/app/discussion/server/methods/createDiscussion.ts and 3 other locations - About 35 mins to fix
    apps/meteor/app/lib/server/functions/sendMessage.ts on lines 90..99
    apps/meteor/client/views/account/profile/AccountProfileForm.tsx on lines 131..131
    apps/meteor/client/views/omnichannel/webhooks/WebhooksPage.tsx on lines 68..77

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 46.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status