RocketChat/Rocket.Chat

View on GitHub
apps/meteor/app/importer/server/classes/Importer.ts

Summary

Maintainability
D
1 day
Test Coverage

Function startImport has a Cognitive Complexity of 41 (exceeds 5 allowed). Consider refactoring.
Open

    async startImport(importSelection: Selection, startedByUserId: string): Promise<ImporterProgress> {
        if (!(importSelection instanceof Selection)) {
            throw new Error(`Invalid Selection data provided to the ${this.info.name} importer.`);
        } else if (importSelection.users === undefined) {
            throw new Error(`Users in the selected data wasn't found, it must but at least an empty array for the ${this.info.name} importer.`);
Severity: Minor
Found in apps/meteor/app/importer/server/classes/Importer.ts - About 6 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function startImport has 104 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    async startImport(importSelection: Selection, startedByUserId: string): Promise<ImporterProgress> {
        if (!(importSelection instanceof Selection)) {
            throw new Error(`Invalid Selection data provided to the ${this.info.name} importer.`);
        } else if (importSelection.users === undefined) {
            throw new Error(`Users in the selected data wasn't found, it must but at least an empty array for the ${this.info.name} importer.`);
Severity: Major
Found in apps/meteor/app/importer/server/classes/Importer.ts - About 4 hrs to fix

    File Importer.ts has 275 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    import { api } from '@rocket.chat/core-services';
    import type { IImport, IImportRecord, IImportChannel, IImportUser, IImportProgress } from '@rocket.chat/core-typings';
    import { Logger } from '@rocket.chat/logger';
    import { Settings, ImportData, Imports } from '@rocket.chat/models';
    import AdmZip from 'adm-zip';
    Severity: Minor
    Found in apps/meteor/app/importer/server/classes/Importer.ts - About 2 hrs to fix

      Avoid too many return statements within this function.
      Open

                          return false;
      Severity: Major
      Found in apps/meteor/app/importer/server/classes/Importer.ts - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

                                    return user.do_import;
        Severity: Major
        Found in apps/meteor/app/importer/server/classes/Importer.ts - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                      return false;
          Severity: Major
          Found in apps/meteor/app/importer/server/classes/Importer.ts - About 30 mins to fix

            Similar blocks of code found in 6 locations. Consider refactoring.
            Open

                    (await Promise.all(promises)).forEach((value, index) => {
                        if (value?.modifiedCount) {
                            void notifyOnSettingChangedById(settingsIds[index]._id);
                        }
                    });
            Severity: Major
            Found in apps/meteor/app/importer/server/classes/Importer.ts and 5 other locations - About 1 hr to fix
            apps/meteor/app/lib/server/methods/saveSettings.ts on lines 120..124
            apps/meteor/app/livechat/imports/server/rest/appearance.ts on lines 96..100
            apps/meteor/app/livechat/server/api/v1/integration.ts on lines 55..59
            apps/meteor/app/livechat/server/methods/saveAppearance.ts on lines 57..61
            apps/meteor/app/livechat/server/methods/saveIntegration.ts on lines 68..72

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 56.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status