Sign upLogin

RocketChat/Rocket.Chat

View on GitHub
Star
apps/meteor/server/ufs/ufs-store.ts

Summary

Maintainability
F
3 days
Test Coverage

Function constructor has 138 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    constructor(options: StoreOptions) {
        options = {
            onCopyError: this.onCopyError,
            onFinishUpload: this.onFinishUpload,
            onRead: this.onRead,
Severity: Major
Found in apps/meteor/server/ufs/ufs-store.ts - About 5 hrs to fix

    Function constructor has a Cognitive Complexity of 25 (exceeds 5 allowed). Consider refactoring.
    Open

        constructor(options: StoreOptions) {
        options = {
            onCopyError: this.onCopyError,
            onFinishUpload: this.onFinishUpload,
            onRead: this.onRead,
    Severity: Minor
    Found in apps/meteor/server/ufs/ufs-store.ts - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    File ufs-store.ts has 286 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    import fs from 'fs';
import type * as http from 'http';
import type stream from 'stream';

import type { IUpload } from '@rocket.chat/core-typings';
    Severity: Minor
    Found in apps/meteor/server/ufs/ufs-store.ts - About 2 hrs to fix

      Store has 24 functions (exceeds 20 allowed). Consider refactoring.
      Open

      export class Store {
    protected options: StoreOptions;

    public copy: (
        fileId: string,
      Severity: Minor
      Found in apps/meteor/server/ufs/ufs-store.ts - About 2 hrs to fix

        Function write has 56 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                this.write = async (rs, fileId, callback) => {
            const file = await this.getCollection().findOne({ _id: fileId });
            if (!file) {
                return callback(new Error('File not found'));
            }
        Severity: Major
        Found in apps/meteor/server/ufs/ufs-store.ts - About 2 hrs to fix

          Function finishHandler has 42 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

                      const finishHandler = async () => {
                let size = 0;
                const readStream = await this.getReadStream(fileId, file);

                readStream.on('error', (error: Error) => {
          Severity: Minor
          Found in apps/meteor/server/ufs/ufs-store.ts - About 1 hr to fix

            Function copy has 29 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                    this.copy = async (fileId, store, callback) => {
            check(fileId, String);

            if (!(store instanceof Store)) {
                throw new TypeError('store is not an instance of UploadFS.Store');
            Severity: Minor
            Found in apps/meteor/server/ufs/ufs-store.ts - About 1 hr to fix

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  async getFileURL(fileId: string) {
        const file = await this.getCollection().findOne(fileId, { projection: { name: 1 } });
        return file ? this.getURL(`${fileId}/${file.name}`) : undefined;
    }
              Severity: Major
              Found in apps/meteor/server/ufs/ufs-store.ts and 1 other location - About 2 hrs to fix
              apps/meteor/server/ufs/ufs-store.ts on lines 266..269

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 84.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  async getFileRelativeURL(fileId: string) {
        const file = await this.getCollection().findOne(fileId, { projection: { name: 1 } });
        return file ? this.getRelativeURL(`${fileId}/${file.name}`) : undefined;
    }
              Severity: Major
              Found in apps/meteor/server/ufs/ufs-store.ts and 1 other location - About 2 hrs to fix
              apps/meteor/server/ufs/ufs-store.ts on lines 271..274

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 84.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                      fs.stat(tmpFile, (err) => {
            !err &&
                fs.unlink(tmpFile, (err2) => {
                    err2 && console.error(`ufs: cannot delete temp file at ${tmpFile} (${err2.message})`);
                });
              Severity: Major
              Found in apps/meteor/server/ufs/ufs-store.ts and 1 other location - About 1 hr to fix
              apps/meteor/server/ufs/ufs-methods.ts on lines 22..27

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 73.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 3 locations. Consider refactoring.
              Open

                  onCopyError(err: Error, fileId: string, _file: IUpload) {
        console.error(`ufs: cannot copy file "${fileId}" (${err.message})`, err);
    }
              Severity: Major
              Found in apps/meteor/server/ufs/ufs-store.ts and 2 other locations - About 1 hr to fix
              apps/meteor/server/ufs/ufs-store.ts on lines 323..325
              apps/meteor/server/ufs/ufs-store.ts on lines 331..333

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 56.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 3 locations. Consider refactoring.
              Open

                  onWriteError(err: Error, fileId: string, _file: IUpload) {
        console.error(`ufs: cannot write file "${fileId}" (${err.message})`, err);
    }
              Severity: Major
              Found in apps/meteor/server/ufs/ufs-store.ts and 2 other locations - About 1 hr to fix
              apps/meteor/server/ufs/ufs-store.ts on lines 311..313
              apps/meteor/server/ufs/ufs-store.ts on lines 323..325

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 56.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 3 locations. Consider refactoring.
              Open

                  onReadError(err: Error, fileId: string, _file: IUpload) {
        console.error(`ufs: cannot read file "${fileId}" (${err.message})`, err);
    }
              Severity: Major
              Found in apps/meteor/server/ufs/ufs-store.ts and 2 other locations - About 1 hr to fix
              apps/meteor/server/ufs/ufs-store.ts on lines 311..313
              apps/meteor/server/ufs/ufs-store.ts on lines 331..333

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 56.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status