RocketChat/Rocket.Chat

View on GitHub

Showing 9,144 of 9,144 total issues

Avoid too many return statements within this function.
Open

    return 'no-role';
Severity: Major
Found in apps/meteor/lib/roles/getMostImportantRole.ts - About 30 mins to fix

    Avoid too many return statements within this function.
    Open

                        return;
    Severity: Major
    Found in ee/apps/ddp-streamer/src/Client.ts - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

          return true;
      Severity: Major
      Found in apps/meteor/ee/app/livechat-enterprise/server/hooks/onTransferFailure.ts - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

              return { ...state };
        Severity: Major
        Found in apps/uikit-playground/src/Context/reducer.ts - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

              return { ...room, chatQueued: true } as IOmnichannelRoom & { chatQueued: boolean };

            Avoid too many return statements within this function.
            Open

                    return false;
            Severity: Major
            Found in apps/meteor/ee/app/livechat-enterprise/server/hooks/onTransferFailure.ts - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                return diagnostics;

                Avoid too many return statements within this function.
                Open

                      return { ...state };
                Severity: Major
                Found in apps/uikit-playground/src/Context/reducer.ts - About 30 mins to fix

                  Avoid too many return statements within this function.
                  Open

                          return null;
                  Severity: Major
                  Found in apps/meteor/ee/app/livechat-enterprise/server/lib/Helper.ts - About 30 mins to fix

                    Avoid too many return statements within this function.
                    Open

                          return { ...state };
                    Severity: Major
                    Found in apps/uikit-playground/src/Context/reducer.ts - About 30 mins to fix

                      Avoid too many return statements within this function.
                      Open

                          return currentOnHoldTime;

                        Avoid too many return statements within this function.
                        Open

                                return affectedUsers.map(({ _id }) => _id);
                        Severity: Major
                        Found in ee/packages/presence/src/Presence.ts - About 30 mins to fix

                          Avoid too many return statements within this function.
                          Open

                              return normalizeQueueInfo(inq);
                          Severity: Major
                          Found in apps/meteor/ee/app/livechat-enterprise/server/lib/Helper.ts - About 30 mins to fix

                            Avoid too many return statements within this function.
                            Open

                                  return {
                                    ...state,
                                    projects: {
                                      ...state.projects,
                                      [activeProjectId]: {
                            Severity: Major
                            Found in apps/uikit-playground/src/Context/reducer.ts - About 30 mins to fix

                              Similar blocks of code found in 3 locations. Consider refactoring.
                              Open

                                      settings.watch('SlackBridge_Reactions_Enabled', (value) => {
                                          this.isReactionsEnabled = value;
                                          classLogger.debug('Setting: SlackBridge_Reactions_Enabled', value);
                                      });
                              Severity: Minor
                              Found in apps/meteor/app/slackbridge/server/slackbridge.js and 2 other locations - About 30 mins to fix
                              apps/meteor/app/slackbridge/server/slackbridge.js on lines 162..165
                              apps/meteor/app/slackbridge/server/slackbridge.js on lines 168..171

                              Duplicated Code

                              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                              Tuning

                              This issue has a mass of 45.

                              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                              Refactorings

                              Further Reading

                              Similar blocks of code found in 2 locations. Consider refactoring.
                              Open

                                          {
                                              $or: [
                                                  {
                                                      scope: 'user',
                                                      userId,
                              apps/meteor/ee/app/api-enterprise/server/lib/canned-responses.js on lines 30..46

                              Duplicated Code

                              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                              Tuning

                              This issue has a mass of 45.

                              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                              Refactorings

                              Further Reading

                              Similar blocks of code found in 3 locations. Consider refactoring.
                              Open

                                      settings.watch('SlackBridge_ExcludeBotnames', (value) => {
                                          this.excludeBotnames = value;
                                          classLogger.debug('Setting: SlackBridge_ExcludeBotnames', value);
                                      });
                              Severity: Minor
                              Found in apps/meteor/app/slackbridge/server/slackbridge.js and 2 other locations - About 30 mins to fix
                              apps/meteor/app/slackbridge/server/slackbridge.js on lines 162..165
                              apps/meteor/app/slackbridge/server/slackbridge.js on lines 174..177

                              Duplicated Code

                              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                              Tuning

                              This issue has a mass of 45.

                              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                              Refactorings

                              Further Reading

                              Similar blocks of code found in 39 locations. Consider refactoring.
                              Open

                                  '/v1/im.messages': {
                                      GET: (params: DmMessagesProps) => PaginatedResult<{
                                          messages: IMessage[];
                                      }>;
                                  };
                              Severity: Major
                              Found in packages/rest-typings/src/v1/dm/im.ts and 38 other locations - About 30 mins to fix
                              packages/rest-typings/src/v1/channels/channels.ts on lines 42..46
                              packages/rest-typings/src/v1/channels/channels.ts on lines 56..60
                              packages/rest-typings/src/v1/channels/channels.ts on lines 133..137
                              packages/rest-typings/src/v1/channels/channels.ts on lines 161..165
                              packages/rest-typings/src/v1/customSounds.ts on lines 39..43
                              packages/rest-typings/src/v1/customUserStatus.ts on lines 39..43
                              packages/rest-typings/src/v1/dm/im.ts on lines 43..47
                              packages/rest-typings/src/v1/email-inbox.ts on lines 160..162
                              packages/rest-typings/src/v1/federation/rooms.ts on lines 17..21
                              packages/rest-typings/src/v1/groups/groups.ts on lines 43..47
                              packages/rest-typings/src/v1/groups/groups.ts on lines 56..60
                              packages/rest-typings/src/v1/groups/groups.ts on lines 101..105
                              packages/rest-typings/src/v1/omnichannel.ts on lines 3518..3522
                              packages/rest-typings/src/v1/omnichannel.ts on lines 3526..3530
                              packages/rest-typings/src/v1/omnichannel.ts on lines 3557..3561
                              packages/rest-typings/src/v1/omnichannel.ts on lines 3578..3582
                              packages/rest-typings/src/v1/omnichannel.ts on lines 3583..3587
                              packages/rest-typings/src/v1/omnichannel.ts on lines 3589..3593
                              packages/rest-typings/src/v1/omnichannel.ts on lines 3605..3609
                              packages/rest-typings/src/v1/omnichannel.ts on lines 3613..3617
                              packages/rest-typings/src/v1/omnichannel.ts on lines 3747..3749
                              packages/rest-typings/src/v1/omnichannel.ts on lines 3848..3850
                              packages/rest-typings/src/v1/omnichannel.ts on lines 3851..3853
                              packages/rest-typings/src/v1/omnichannel.ts on lines 3854..3858
                              packages/rest-typings/src/v1/omnichannel.ts on lines 3882..3884
                              packages/rest-typings/src/v1/omnichannel.ts on lines 3905..3907
                              packages/rest-typings/src/v1/omnichannel.ts on lines 3911..3913
                              packages/rest-typings/src/v1/omnichannel.ts on lines 3914..3916
                              packages/rest-typings/src/v1/omnichannel.ts on lines 4015..4019
                              packages/rest-typings/src/v1/omnichannel.ts on lines 4020..4024
                              packages/rest-typings/src/v1/rooms.ts on lines 744..748
                              packages/rest-typings/src/v1/rooms.ts on lines 762..766
                              packages/rest-typings/src/v1/teams/index.ts on lines 190..192
                              packages/rest-typings/src/v1/users.ts on lines 153..157
                              packages/rest-typings/src/v1/videoConference/index.ts on lines 33..35
                              packages/rest-typings/src/v1/voip.ts on lines 543..545
                              packages/rest-typings/src/v1/voip.ts on lines 558..560
                              packages/rest-typings/src/v1/voip.ts on lines 576..578

                              Duplicated Code

                              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                              Tuning

                              This issue has a mass of 45.

                              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                              Refactorings

                              Further Reading

                              Similar blocks of code found in 39 locations. Consider refactoring.
                              Open

                                  '/v1/rooms.getDiscussions': {
                                      GET: (params: RoomsGetDiscussionsProps) => PaginatedResult<{
                                          discussions: IRoom[];
                                      }>;
                                  };
                              Severity: Major
                              Found in packages/rest-typings/src/v1/rooms.ts and 38 other locations - About 30 mins to fix
                              packages/rest-typings/src/v1/channels/channels.ts on lines 42..46
                              packages/rest-typings/src/v1/channels/channels.ts on lines 56..60
                              packages/rest-typings/src/v1/channels/channels.ts on lines 133..137
                              packages/rest-typings/src/v1/channels/channels.ts on lines 161..165
                              packages/rest-typings/src/v1/customSounds.ts on lines 39..43
                              packages/rest-typings/src/v1/customUserStatus.ts on lines 39..43
                              packages/rest-typings/src/v1/dm/im.ts on lines 43..47
                              packages/rest-typings/src/v1/dm/im.ts on lines 59..63
                              packages/rest-typings/src/v1/email-inbox.ts on lines 160..162
                              packages/rest-typings/src/v1/federation/rooms.ts on lines 17..21
                              packages/rest-typings/src/v1/groups/groups.ts on lines 43..47
                              packages/rest-typings/src/v1/groups/groups.ts on lines 56..60
                              packages/rest-typings/src/v1/groups/groups.ts on lines 101..105
                              packages/rest-typings/src/v1/omnichannel.ts on lines 3518..3522
                              packages/rest-typings/src/v1/omnichannel.ts on lines 3526..3530
                              packages/rest-typings/src/v1/omnichannel.ts on lines 3557..3561
                              packages/rest-typings/src/v1/omnichannel.ts on lines 3578..3582
                              packages/rest-typings/src/v1/omnichannel.ts on lines 3583..3587
                              packages/rest-typings/src/v1/omnichannel.ts on lines 3589..3593
                              packages/rest-typings/src/v1/omnichannel.ts on lines 3605..3609
                              packages/rest-typings/src/v1/omnichannel.ts on lines 3613..3617
                              packages/rest-typings/src/v1/omnichannel.ts on lines 3747..3749
                              packages/rest-typings/src/v1/omnichannel.ts on lines 3848..3850
                              packages/rest-typings/src/v1/omnichannel.ts on lines 3851..3853
                              packages/rest-typings/src/v1/omnichannel.ts on lines 3854..3858
                              packages/rest-typings/src/v1/omnichannel.ts on lines 3882..3884
                              packages/rest-typings/src/v1/omnichannel.ts on lines 3905..3907
                              packages/rest-typings/src/v1/omnichannel.ts on lines 3911..3913
                              packages/rest-typings/src/v1/omnichannel.ts on lines 3914..3916
                              packages/rest-typings/src/v1/omnichannel.ts on lines 4015..4019
                              packages/rest-typings/src/v1/omnichannel.ts on lines 4020..4024
                              packages/rest-typings/src/v1/rooms.ts on lines 762..766
                              packages/rest-typings/src/v1/teams/index.ts on lines 190..192
                              packages/rest-typings/src/v1/users.ts on lines 153..157
                              packages/rest-typings/src/v1/videoConference/index.ts on lines 33..35
                              packages/rest-typings/src/v1/voip.ts on lines 543..545
                              packages/rest-typings/src/v1/voip.ts on lines 558..560
                              packages/rest-typings/src/v1/voip.ts on lines 576..578

                              Duplicated Code

                              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                              Tuning

                              This issue has a mass of 45.

                              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                              Refactorings

                              Further Reading

                              Similar blocks of code found in 39 locations. Consider refactoring.
                              Open

                                  '/v1/video-conference.list': {
                                      GET: (params: VideoConfListProps) => PaginatedResult<{ data: VideoConference[] }>;
                                  };
                              Severity: Major
                              Found in packages/rest-typings/src/v1/videoConference/index.ts and 38 other locations - About 30 mins to fix
                              packages/rest-typings/src/v1/channels/channels.ts on lines 42..46
                              packages/rest-typings/src/v1/channels/channels.ts on lines 56..60
                              packages/rest-typings/src/v1/channels/channels.ts on lines 133..137
                              packages/rest-typings/src/v1/channels/channels.ts on lines 161..165
                              packages/rest-typings/src/v1/customSounds.ts on lines 39..43
                              packages/rest-typings/src/v1/customUserStatus.ts on lines 39..43
                              packages/rest-typings/src/v1/dm/im.ts on lines 43..47
                              packages/rest-typings/src/v1/dm/im.ts on lines 59..63
                              packages/rest-typings/src/v1/email-inbox.ts on lines 160..162
                              packages/rest-typings/src/v1/federation/rooms.ts on lines 17..21
                              packages/rest-typings/src/v1/groups/groups.ts on lines 43..47
                              packages/rest-typings/src/v1/groups/groups.ts on lines 56..60
                              packages/rest-typings/src/v1/groups/groups.ts on lines 101..105
                              packages/rest-typings/src/v1/omnichannel.ts on lines 3518..3522
                              packages/rest-typings/src/v1/omnichannel.ts on lines 3526..3530
                              packages/rest-typings/src/v1/omnichannel.ts on lines 3557..3561
                              packages/rest-typings/src/v1/omnichannel.ts on lines 3578..3582
                              packages/rest-typings/src/v1/omnichannel.ts on lines 3583..3587
                              packages/rest-typings/src/v1/omnichannel.ts on lines 3589..3593
                              packages/rest-typings/src/v1/omnichannel.ts on lines 3605..3609
                              packages/rest-typings/src/v1/omnichannel.ts on lines 3613..3617
                              packages/rest-typings/src/v1/omnichannel.ts on lines 3747..3749
                              packages/rest-typings/src/v1/omnichannel.ts on lines 3848..3850
                              packages/rest-typings/src/v1/omnichannel.ts on lines 3851..3853
                              packages/rest-typings/src/v1/omnichannel.ts on lines 3854..3858
                              packages/rest-typings/src/v1/omnichannel.ts on lines 3882..3884
                              packages/rest-typings/src/v1/omnichannel.ts on lines 3905..3907
                              packages/rest-typings/src/v1/omnichannel.ts on lines 3911..3913
                              packages/rest-typings/src/v1/omnichannel.ts on lines 3914..3916
                              packages/rest-typings/src/v1/omnichannel.ts on lines 4015..4019
                              packages/rest-typings/src/v1/omnichannel.ts on lines 4020..4024
                              packages/rest-typings/src/v1/rooms.ts on lines 744..748
                              packages/rest-typings/src/v1/rooms.ts on lines 762..766
                              packages/rest-typings/src/v1/teams/index.ts on lines 190..192
                              packages/rest-typings/src/v1/users.ts on lines 153..157
                              packages/rest-typings/src/v1/voip.ts on lines 543..545
                              packages/rest-typings/src/v1/voip.ts on lines 558..560
                              packages/rest-typings/src/v1/voip.ts on lines 576..578

                              Duplicated Code

                              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                              Tuning

                              This issue has a mass of 45.

                              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                              Refactorings

                              Further Reading

                              Severity
                              Category
                              Status
                              Source
                              Language