RolandJansen/intermix.js

Similar blocks of code found in 2 locations. Consider refactoring.

Open

        test("activates loop mode", () => {
            sequencer["score"]["loopActive"] = false;
            sequencer.onChange(["loopActive", 1]);
            expect(sequencer["score"]["loopActive"]).toBeTruthy();
        });

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

        test("deactivates loop mode", () => {
            sequencer["score"]["loopActive"] = true;
            sequencer.onChange(["loopActive", 0]);
            expect(sequencer["score"]["loopActive"]).toBeFalsy();
        });

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    public readonly actionDefs: IOscActionDef[] = [
        {
            address: "/intermix/plugin/<UID>/ACTION1",
            typeTag: ",i",
            value: 0,

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    public actionDefs: IOscActionDef[] = [
        {
            address: "/intermix/plugin/<UID>/ACTION1",
            typeTag: ",i",
            value: 0,

• Read up
  Read up

Function getActionCreators has 34 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    protected getActionCreators(actionDefs: IOscActionDef[], uid: string): ActionCreatorsMapObject {
        const actionCreators: ActionCreatorsMapObject = {};

        actionDefs.forEach((actionDef) => {
            // make a physical copy of actionDef. If not, we would

Similar blocks of code found in 3 locations. Consider refactoring.

Open

    test("adds action creator functions to the SeqPart instance", () => {
        const acKeys = Object.keys(testPart.actionCreators);
        expect(acKeys).toContain("addNote");
        expect(acKeys).toContain("removeNote");
    });

• Read up
  Read up

Similar blocks of code found in 3 locations. Consider refactoring.

Open

    test("adds unbound action creators to the plugin instance", () => {
        const acKeys = Object.keys(testPlugin.unboundActionCreators);
        expect(acKeys).toContain("ACTION1");
        expect(acKeys).toContain("ACTION2");
    });

• Read up
  Read up

Similar blocks of code found in 3 locations. Consider refactoring.

Open

    test("adds action creator functions to the plugin instance", () => {
        const acKeys = Object.keys(testPlugin.actionCreators);
        expect(acKeys).toContain("ACTION1");
        expect(acKeys).toContain("ACTION2");
    });

• Read up
  Read up

Similar blocks of code found in 3 locations. Consider refactoring.

Open

    test("has a metadata section (static)", () => {
        expect(Synth.METADATA.type).toEqual("instrument");
        expect(Synth.METADATA.name).toEqual("Intermix Synth");
    });

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    if (original instanceof Map) {
        if (original.size !== 0) {
            return new Map(deepCopy(Array.from(original))) as any;
        }
        return new Map() as any;

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    if (original instanceof Set) {
        if (original.size !== 0) {
            return new Set(deepCopy(Array.from(original))) as any;
        }
        return new Set() as any;

• Read up
  Read up

Similar blocks of code found in 3 locations. Consider refactoring.

Open

    test("has a metadata section (static)", () => {
        expect(Sampler.METADATA.type).toEqual("instrument");
        expect(Sampler.METADATA.name).toEqual("Intermix Sampler");
    });

• Read up
  Read up

Similar blocks of code found in 3 locations. Consider refactoring.

Open

    test("has a static metadata section", () => {
        expect(Sequencer.METADATA.type).toEqual("controller");
        expect(Sequencer.METADATA.name).toEqual("Intermix Sequencer");
    });

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    public removeSeqPart(itemId: string): void {
        this.seqParts.remove(itemId);
        this.replaceReducer();
        store.dispatch(removePart(itemId));
    }

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    public removePlugin(itemId: string): void {
        this.plugins.remove(itemId);
        this.replaceReducer();
        store.dispatch(removePluginAction(itemId));
    }

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

export function getRandomNumberArray(arrLength: number, intLength: number): number[] {
    const numbers = new Array(arrLength);
    for (let i = 0; i <= arrLength; i++) {
        numbers[i] = getRandomInt(intLength);
    }

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

export function getRandomStringArray(arrLength: number, strLength: number): string[] {
    const strings = new Array(arrLength);
    for (let i = 0; i <= arrLength; i++) {
        strings[i] = getRandomString(strLength);
    }

• Read up
  Read up

Function savePreset has 26 lines of code (exceeds 25 allowed). Consider refactoring.

Open

const savePreset: reducerLogic = (mySubState: IState, action: InternalAction): IState => {
    const actionDefs: IOscActionDef[] = mySubState.actionDefs as IOscActionDef[];
    const newPreset: IState = {};
    const commonActionAddresses = new Set();

Similar blocks of code found in 2 locations. Consider refactoring.

Open

        if (pluginKeys.includes(itemId)) {
            const item = this.plugins.itemList.get(itemId);
            if (item) {
                actionCreators = Object.assign({}, item[actionCreatorsType]);
            }

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

        } else if (seqPartKeys.includes(itemId)) {
            const item = this.seqParts.itemList.get(itemId);
            if (item) {
                actionCreators = Object.assign({}, item[actionCreatorsType]);
            }

• Read up
  Read up