SAREhub/EasyECA

View on GitHub
src/SAREhub/EasyECA/DI/Rule/Processor/ReloadRuleGroup/ReloadRuleGroupProcessorDefinitions.php

Summary

Maintainability
A
0 mins
Test Coverage

Avoid using static access to class '\SAREhub\Client\DI\Processor\ProcessorDefinitionHelper' in method 'actionTransformToRuleGroupEventRouter'.
Open

        return ProcessorDefinitionHelper::router($routingFunction, $routes);

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\SAREhub\Client\DI\Processor\ProcessorDefinitionHelper' in method 'processor'.
Open

        return ProcessorDefinitionHelper::pipeline([
            static::actionTransformToRuleGroupEventRouter(),
            factory(ReconfigureRuleGroupProcessorProvider::class)
        ]);

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\SAREhub\Client\DI\Processor\ProcessorDefinitionHelper' in method 'wrapCallableFunction'.
Open

        return $function instanceof \Closure ? ProcessorDefinitionHelper::closureValue($function) : $function;

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

The abstract declaration must precede the visibility declaration
Open

    protected abstract static function actionRoutingFunction();

The abstract declaration must precede the visibility declaration
Open

    protected abstract static function ruleGroupIdExtractor();

The abstract declaration must precede the visibility declaration
Open

    protected abstract static function ruleGroupRulesExtractor();

There are no issues that match your filters.

Category
Status