Sign upLogin

SAREhub/EasyECA

View on GitHub
Star

Showing 47 of 50 total issues

Avoid excessively long class names like DefaultEventTypeRuleGroupsSplittingStrategy. Keep class name length under 40.
Open

class DefaultEventTypeRuleGroupsSplittingStrategy implements SplittingStrategy
{
    /**
     * @var EventRuleGroupDefinitionFactory
     */
Severity: Minor
Found in src/SAREhub/EasyECA/Event/DefaultEventTypeRuleGroupsSplittingStrategy.php by phpmd

LongClassName

Since: 2.9

Detects when classes or interfaces are declared with excessively long names.

Example

class ATooLongClassNameThatHintsAtADesignProblem {

}

interface ATooLongInterfaceNameThatHintsAtADesignProblem {

}

Source https://phpmd.org/rules/naming.html#longclassname

The class RuleDefinitions has a coupling between objects value of 13. Consider to reduce the number of dependencies under 13.
Open

class RuleDefinitions
{
    public static function get(): array
    {
        return [
Severity: Minor
Found in src/SAREhub/EasyECA/DI/Rule/RuleDefinitions.php by phpmd

CouplingBetweenObjects

Since: 1.1.0

A class with too many dependencies has negative impacts on several quality aspects of a class. This includes quality criteria like stability, maintainability and understandability

Example

class Foo {
    /**
     * @var \foo\bar\X
     */
    private $x = null;

    /**
     * @var \foo\bar\Y
     */
    private $y = null;

    /**
     * @var \foo\bar\Z
     */
    private $z = null;

    public function setFoo(\Foo $foo) {}
    public function setBar(\Bar $bar) {}
    public function setBaz(\Baz $baz) {}

    /**
     * @return \SplObjectStorage
     * @throws \OutOfRangeException
     * @throws \InvalidArgumentException
     * @throws \ErrorException
     */
    public function process(\Iterator $it) {}

    // ...
}

Source https://phpmd.org/rules/design.html#couplingbetweenobjects

The class RuleDefinitions has a coupling between objects value of 13. Consider to reduce the number of dependencies under 13.
Open

class RuleDefinitions
{
    public static function get(): array
    {
        return [
Severity: Minor
Found in src/SAREhub/EasyECA/DI/Rule/RuleDefinitions.php by phpmd

CouplingBetweenObjects

Since: 1.1.0

A class with too many dependencies has negative impacts on several quality aspects of a class. This includes quality criteria like stability, maintainability and understandability

Example

class Foo {
    /**
     * @var \foo\bar\X
     */
    private $x = null;

    /**
     * @var \foo\bar\Y
     */
    private $y = null;

    /**
     * @var \foo\bar\Z
     */
    private $z = null;

    public function setFoo(\Foo $foo) {}
    public function setBar(\Bar $bar) {}
    public function setBaz(\Baz $baz) {}

    /**
     * @return \SplObjectStorage
     * @throws \OutOfRangeException
     * @throws \InvalidArgumentException
     * @throws \ErrorException
     */
    public function process(\Iterator $it) {}

    // ...
}

Source https://phpmd.org/rules/design.html#couplingbetweenobjects

There must be one blank line after the namespace declaration
Open

namespace SAREhub\EasyECA\Rule\Loader\Http;
Severity: Minor
Found in src/SAREhub/EasyECA/Rule/Loader/Http/HttpEventRuleGroupsLoader.php by phpcodesniffer

There must be one blank line after the namespace declaration
Open

namespace SAREhub\EasyECA\Rule\Loader;
Severity: Minor
Found in src/SAREhub/EasyECA/Rule/Loader/EventRuleGroupsLoader.php by phpcodesniffer

The closing brace for the class must go on the next line after the body
Open

}
Severity: Minor
Found in src/SAREhub/EasyECA/Event/DefaultEventTypeRuleGroupsSplittingStrategy.php by phpcodesniffer

The abstract declaration must precede the visibility declaration
Open

    protected abstract static function actionRoutingFunction();
Severity: Minor
Found in src/SAREhub/EasyECA/DI/Rule/Processor/ReloadRuleGroup/ReloadRuleGroupProcessorDefinitions.php by phpcodesniffer

There must be one blank line after the namespace declaration
Open

namespace SAREhub\EasyECA\Rule;
Severity: Minor
Found in src/SAREhub/EasyECA/Rule/EventRuleGroupManager.php by phpcodesniffer

Expected 1 blank line at end of file; 2 found
Open

}
Severity: Minor
Found in src/SAREhub/EasyECA/Rule/RuleParser.php by phpcodesniffer

The abstract declaration must precede the visibility declaration
Open

    protected abstract static function ruleGroupIdExtractor();
Severity: Minor
Found in src/SAREhub/EasyECA/DI/Rule/Processor/ReloadRuleGroup/ReloadRuleGroupProcessorDefinitions.php by phpcodesniffer

There must be one blank line after the namespace declaration
Open

namespace SAREhub\EasyECA\Rule;
Severity: Minor
Found in src/SAREhub/EasyECA/Rule/AddRuleGroupListener.php by phpcodesniffer

There must be one blank line after the namespace declaration
Open

namespace SAREhub\EasyECA\Rule\Definition;
Severity: Minor
Found in src/SAREhub/EasyECA/Rule/Definition/EventRuleGroupDefinition.php by phpcodesniffer

There must be one blank line after the namespace declaration
Open

namespace SAREhub\EasyECA\Rule;
Severity: Minor
Found in src/SAREhub/EasyECA/Rule/RemoveGroupFromAllEventsListener.php by phpcodesniffer

There must be one blank line after the namespace declaration
Open

namespace SAREhub\EasyECA\Rule;
Severity: Minor
Found in src/SAREhub/EasyECA/Rule/RuleGroupParser.php by phpcodesniffer

The abstract declaration must precede the visibility declaration
Open

    protected abstract static function ruleGroupRulesExtractor();
Severity: Minor
Found in src/SAREhub/EasyECA/DI/Rule/Processor/ReloadRuleGroup/ReloadRuleGroupProcessorDefinitions.php by phpcodesniffer

There must be one blank line after the namespace declaration
Open

namespace SAREhub\EasyECA\Rule\Definition;
Severity: Minor
Found in src/SAREhub/EasyECA/Rule/Definition/EventRuleGroupDefinitionFactory.php by phpcodesniffer

Missing class import via use statement (line '14', column '23').
Open

            throw new \InvalidArgumentException("ActionDefinition data is invalid: empty action");
Severity: Minor
Found in src/SAREhub/EasyECA/Rule/Action/ActionDefinitionFactory.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '35', column '23').
Open

            throw new \InvalidArgumentException("RuleDefinition data is invalid: onPass or onFail must be defined");
Severity: Minor
Found in src/SAREhub/EasyECA/Rule/Definition/RuleDefinitionFactory.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '31', column '24').
Open

            throw  new \InvalidArgumentException("RuleDefinition data is invalid: empty condition");
Severity: Minor
Found in src/SAREhub/EasyECA/Rule/Definition/RuleDefinitionFactory.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '35', column '23').
Open

            throw new \InvalidArgumentException("RuleDefinition data is invalid: onPass or onFail must be defined");
Severity: Minor
Found in src/SAREhub/EasyECA/Rule/Definition/RuleDefinitionFactory.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Severity
Category
Status
Source
Language