src/SAREhub/Commons/Misc/GenericFactory.php
Missing class import via use statement (line '26', column '19'). Open
Open
throw new \Exception("creator with name '" . $creatorName . "' not registered");
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Avoid assigning values to variables in if clauses and the like (line '22', column '13'). Open
Open
public function create($creatorName, $data = null)
{
if ($creator = $this->getCreator($creatorName)) {
return $creator($data);
}
- Read upRead up
- Exclude checks
IfStatementAssignment
Since: 2.7.0
Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.
Example
class Foo
{
public function bar($flag)
{
if ($foo = 'bar') { // possible typo
// ...
}
if ($baz = 0) { // always false
// ...
}
}
}
Source http://phpmd.org/rules/cleancode.html#ifstatementassignment
The closing brace for the class must go on the next line after the body Open
Open
}
- Exclude checks
Expected 1 newline at end of file; 0 found Open
Open
}
- Exclude checks