Sign upLogin

SAREhub/PHP_Commons

View on GitHub
Star
src/SAREhub/Commons/Zmq/PublishSubscribe/Publisher.php

Summary

Maintainability
A
0 mins
Test Coverage

Missing class import via use statement (line '35', column '23').
Open

            throw new \LogicException("Publishing message when not binded or connected");
Severity: Minor
Found in src/SAREhub/Commons/Zmq/PublishSubscribe/Publisher.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

The method publish has a boolean flag argument $wait, which is a certain sign of a Single Responsibility Principle violation.
Open

    public function publish($topic, $message, $wait = false)
Severity: Minor
Found in src/SAREhub/Commons/Zmq/PublishSubscribe/Publisher.php by phpmd

BooleanArgumentFlag

Since: 1.4.0

A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

Example

class Foo {
    public function bar($flag = true) {
    }
}

Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

Expected 1 newline at end of file; 0 found
Open

}
Severity: Minor
Found in src/SAREhub/Commons/Zmq/PublishSubscribe/Publisher.php by phpcodesniffer

There are no issues that match your filters.

Category
Status