Sign upLogin

SU-HKKU/cardinal_service_profile

View on GitHub
Star
cardinal_service_profile.inc

Summary

Maintainability
Test Coverage

The function cardinal_service_profile_entity_field_access() has a Cyclomatic Complexity of 10. The configured cyclomatic complexity threshold is 10.
Open

function cardinal_service_profile_entity_field_access($operation, FieldDefinitionInterface $field_definition, AccountInterface $account, FieldItemListInterface $items = NULL) {
  $route_match = \Drupal::routeMatch();

  // When the user is viwing the node detail page, hide some of the fields
  // based on other fields having some data.
Severity: Minor
Found in cardinal_service_profile.inc by phpmd

CyclomaticComplexity

Since: 0.1

Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

Example

// Cyclomatic Complexity = 11
class Foo {
1   public function example() {
2       if ($a == $b) {
3           if ($a1 == $b1) {
                fiddle();
4           } elseif ($a2 == $b2) {
                fiddle();
            } else {
                fiddle();
            }
5       } elseif ($c == $d) {
6           while ($c == $d) {
                fiddle();
            }
7        } elseif ($e == $f) {
8           for ($n = 0; $n < $h; $n++) {
                fiddle();
            }
        } else {
            switch ($z) {
9               case 1:
                    fiddle();
                    break;
10              case 2:
                    fiddle();
                    break;
11              case 3:
                    fiddle();
                    break;
                default:
                    fiddle();
                    break;
            }
        }
    }
}

Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

Avoid assigning values to variables in if clauses and the like (line '341', column '7').
Open

function _cardinal_service_profile_field_mapped(NodeInterface $node, FieldDefinitionInterface $field) {
  $field_name = $field->getName();
  $columns = $field->getFieldStorageDefinition()->getColumns();

  if ($migration_name = _cardinal_service_node_imported($node)) {
Severity: Minor
Found in cardinal_service_profile.inc by phpmd

IfStatementAssignment

Since: 2.7.0

Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

Example

class Foo
{
    public function bar($flag)
    {
        if ($foo = 'bar') { // possible typo
            // ...
        }
        if ($baz = 0) { // always false
            // ...
        }
    }
}

Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

Invalid offset "cs_resources" of array type array{su_opportunities:array<int>}</int>
Invalid

    foreach ($info['displays']['cs_resources'] as $key => $display) {
Severity: Minor
Found in cardinal_service_profile.inc by phan

null passed to foreach instead of array
Invalid

    foreach ($info['displays']['cs_resources'] as $key => $display) {
Severity: Minor
Found in cardinal_service_profile.inc by phan

Invalid offset "cs_resources" of array type array{su_opportunities:array<int>}</int>
Invalid

    $info['displays']['cs_resources'] = array_values($info['displays']['cs_resources']);
Severity: Minor
Found in cardinal_service_profile.inc by phan

Argument 1 (input) is null but \array_values() takes array
Invalid

    $info['displays']['cs_resources'] = array_values($info['displays']['cs_resources']);
Severity: Minor
Found in cardinal_service_profile.inc by phan

Object operator not indented correctly; expected 4 spaces but found 6
Open

      ->getString() === $node->label()) {
Severity: Minor
Found in cardinal_service_profile.inc by phpcodesniffer

Doc comment indicates hook_form_alter() but function signature is "cardinal_service_profile_form_alter" instead of "cardinal_service_profile.info_form_alter". Did you mean hook_form_FORM_ID_alter()?
Invalid

 * Implements hook_form_alter().
Severity: Minor
Found in cardinal_service_profile.inc by phpcodesniffer

There are no issues that match your filters.

Category
Status