Sign upLogin

SU-HKKU/cardinal_service_profile

View on GitHub
Star

Showing 66 of 150 total issues

Avoid excessively long variable names like $dependency_definition. Keep variable name length under 20.
Open

      $dependency_definition = $this->getDefinition($dependency);
Severity: Minor
Found in src/InstallTaskManager.php by phpmd

Similar blocks of code found in 5 locations. Consider refactoring.
Open

  protected function getLaunchWebsite() {
    $help = '<h3>' . $this->t('Ready to Launch?') . '</h3>';
    // @TODO: Update link when launch process guide is available.
    $help .= '<p>' . $this->t('Learn about the launch process, review the final checklist, and submit a request to launch.') . '</p>';
    $help .= self::getLinkString($this->t('Website launch process'), 'https://userguide.sites.stanford.edu/support/launching-your-site', TRUE);
Severity: Major
Found in src/Plugin/HelpSection/ProfileHelpSection.php and 4 other locations - About 1 hr to fix
src/Plugin/HelpSection/ProfileHelpSection.php on lines 41..46
src/Plugin/HelpSection/ProfileHelpSection.php on lines 87..92
src/Plugin/HelpSection/ProfileHelpSection.php on lines 100..105
src/Plugin/HelpSection/ProfileHelpSection.php on lines 113..118

Similar blocks of code found in 5 locations. Consider refactoring.
Open

  protected function getContact() {
    $help = '<h3>' . $this->t("Can't find what you're looking for?") . '</h3>';
    $help .= '<p>' . $this->t("We'll help you find the answer or connect you with an advisor.") . '</p>';
    $help .= self::getLinkString($this->t('Stanford Web Services ServiceNow Form'), 'https://stanford.service-now.com/it_services?id=sc_cat_item&sys_id=83daed294f4143009a9a97411310c70a', TRUE);
    return ['#markup' => $help];
Severity: Major
Found in src/Plugin/HelpSection/ProfileHelpSection.php and 4 other locations - About 1 hr to fix
src/Plugin/HelpSection/ProfileHelpSection.php on lines 41..46
src/Plugin/HelpSection/ProfileHelpSection.php on lines 54..60
src/Plugin/HelpSection/ProfileHelpSection.php on lines 87..92
src/Plugin/HelpSection/ProfileHelpSection.php on lines 100..105

Similar blocks of code found in 5 locations. Consider refactoring.
Open

  protected function getUserGuide() {
    $help = '<h3>' . $this->t('Stanford Sites User Guide') . '</h3>';
    $help .= '<p>' . $this->t('Everything you need to know about how to use, maintain, and launch your Website.') . '</p>';
    $help .= self::getLinkString($this->t('User Guide'), 'https://userguide.sites.stanford.edu', TRUE);
    return ['#markup' => $help];
Severity: Major
Found in src/Plugin/HelpSection/ProfileHelpSection.php and 4 other locations - About 1 hr to fix
src/Plugin/HelpSection/ProfileHelpSection.php on lines 54..60
src/Plugin/HelpSection/ProfileHelpSection.php on lines 87..92
src/Plugin/HelpSection/ProfileHelpSection.php on lines 100..105
src/Plugin/HelpSection/ProfileHelpSection.php on lines 113..118

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  public static function create(ContainerInterface $container, array $configuration, $plugin_id, $plugin_definition) {
    return new static(
      $configuration,
      $plugin_id,
      $plugin_definition,
Severity: Major
Found in src/Plugin/InstallTask/SiteSettings.php and 1 other location - About 1 hr to fix
modules/cardinal_service_blocks/src/Plugin/Block/UserLinksBlock.php on lines 64..75

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  public static function create(ContainerInterface $container, array $configuration, $plugin_id, $plugin_definition) {
    return new static(
      $configuration,
      $plugin_id,
      $plugin_definition,
Severity: Major
Found in modules/cardinal_service_blocks/src/Plugin/Block/UserLinksBlock.php and 1 other location - About 1 hr to fix
src/Plugin/InstallTask/SiteSettings.php on lines 67..78

Similar blocks of code found in 5 locations. Consider refactoring.
Open

  protected function getFeedback() {
    $help = '<h3>' . $this->t('Do you have feedback for us?') . '</h3>';
    $help .= '<p>' . $this->t('Submit Feedback to our Drupal service through our ServiceNow form') . '</p>';
    $help .= self::getLinkString($this->t('Stanford Web Services ServiceNow Form'), 'https://stanford.service-now.com/it_services?id=sc_cat_item&sys_id=83daed294f4143009a9a97411310c70a', TRUE);
    return ['#markup' => $help];
Severity: Major
Found in src/Plugin/HelpSection/ProfileHelpSection.php and 4 other locations - About 1 hr to fix
src/Plugin/HelpSection/ProfileHelpSection.php on lines 41..46
src/Plugin/HelpSection/ProfileHelpSection.php on lines 54..60
src/Plugin/HelpSection/ProfileHelpSection.php on lines 87..92
src/Plugin/HelpSection/ProfileHelpSection.php on lines 113..118

Similar blocks of code found in 5 locations. Consider refactoring.
Open

  protected function getAssistance() {
    $help = '<h3>' . $this->t('Need assistance?') . '</h3>';
    $help .= '<p>' . $this->t('Submit a ServiceNow request to Stanford Web Services to request assistance with your website.') . '</p>';
    $help .= self::getLinkString($this->t('Stanford Web Services ServiceNow Form'), 'https://stanford.service-now.com/it_services?id=sc_cat_item&sys_id=83daed294f4143009a9a97411310c70a', TRUE);
    return ['#markup' => $help];
Severity: Major
Found in src/Plugin/HelpSection/ProfileHelpSection.php and 4 other locations - About 1 hr to fix
src/Plugin/HelpSection/ProfileHelpSection.php on lines 41..46
src/Plugin/HelpSection/ProfileHelpSection.php on lines 54..60
src/Plugin/HelpSection/ProfileHelpSection.php on lines 100..105
src/Plugin/HelpSection/ProfileHelpSection.php on lines 113..118

Similar blocks of code found in 2 locations. Consider refactoring.
Open

      {
        test: /\.(svg)$/i,
        use: [
          // A loader for webpack which transforms files into base64 URIs.
          // https://github.com/webpack-contrib/url-loader
Severity: Major
Found in themes/cardinal_service/webpack.config.js and 1 other location - About 1 hr to fix
themes/cardinal_service/webpack.config.js on lines 131..152

Similar blocks of code found in 2 locations. Consider refactoring.
Open

      {
        test: /\.(png|jpg|gif)$/i,
        use: [
          // A loader for webpack which transforms files into base64 URIs.
          // https://github.com/webpack-contrib/url-loader
Severity: Major
Found in themes/cardinal_service/webpack.config.js and 1 other location - About 1 hr to fix
themes/cardinal_service/webpack.config.js on lines 154..175

Similar blocks of code found in 2 locations. Consider refactoring.
Open

const componentStyles = glob.sync('./lib/components/**/*.scss').reduce((acc, path) => {
  const entry = path.replace('.scss', '').replace('./lib/', '');
  acc[entry] = path
  return acc
}, {});
Severity: Major
Found in themes/cardinal_service/webpack.config.js and 1 other location - About 1 hr to fix
themes/cardinal_service/pdb_components/webpack.config.js on lines 5..9

Method runTask has 36 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  public function runTask(array &$install_state) {
    $this->state->set('nobots', FALSE);
 
    $node_pages = [
      '403_page' => '4b8018dc-49a6-4018-9c54-e8c3e462beee',
Severity: Minor
Found in src/Plugin/InstallTask/SiteSettings.php - About 1 hr to fix

    Method getSnowData has 33 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      protected function getSnowData($site_name) {
        $api_url = Settings::get('cardinal_service_profile_snow_api_url', self::SNOW_API);
        try {
          $response = $this->client->request('GET', $api_url, [
            'query' => ['website_address' => $site_name],
    Severity: Minor
    Found in src/Plugin/InstallTask/SiteSettings.php - About 1 hr to fix

      Avoid using undefined variables such as '$events' which will lead to PHP notices.
      Open

          return $events;
      Severity: Minor
      Found in modules/cardinal_service_blocks/src/EventSubscriber/BlockEventSubscriber.php by phpmd

      Avoid using undefined variables such as '$help' which will lead to PHP notices.
      Open

          return $help;
      Severity: Minor
      Found in modules/cardinal_service_profile_helper/src/Form/CsvImporterForm.php by phpmd

      Avoid using undefined variables such as '$events' which will lead to PHP notices.
      Open

          $events[LayoutBuilderEvents::SECTION_COMPONENT_BUILD_RENDER_ARRAY] = [
      Severity: Minor
      Found in modules/cardinal_service_blocks/src/EventSubscriber/BlockEventSubscriber.php by phpmd

      Avoid using undefined variables such as '$help' which will lead to PHP notices.
      Open

          $help[] = [
      Severity: Minor
      Found in modules/cardinal_service_profile_helper/src/Form/CsvImporterForm.php by phpmd

      Avoid using undefined variables such as '$help' which will lead to PHP notices.
      Open

          $help[] = [
      Severity: Minor
      Found in modules/cardinal_service_profile_helper/src/Form/CsvImporterForm.php by phpmd

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

        protected function getBlog() {
          $help = '<h3>' . self::getLinkString($this->t('Stanford Web Services Blog'), 'https://swsblog.stanford.edu/') . '</h3>';
          $help .= '<p>' . $this->t('The Stanford Web Services team blogs about all things related to Stanford Sites, Drupal, design, site building, and many other topics. This is a great resource for SWS clients.') . '</p>';
          return ['#markup' => $help];
        }
      Severity: Major
      Found in src/Plugin/HelpSection/ProfileResourceSection.php and 2 other locations - About 45 mins to fix
      src/Plugin/HelpSection/ProfileResourceSection.php on lines 38..42
      src/Plugin/HelpSection/ProfileResourceSection.php on lines 62..66

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

        protected function getMorningOfCode() {
          $help = '<h3>' . self::getLinkString($this->t("Mornings o' Code, Drupallers Drop-in Help, Drupallers Co-Working Sessions"), 'https://opensource.stanford.edu/moc') . '</h3>';
          $help .= '<p>' . $this->t("Stanford Drupallers (new and experienced) meet regularly to collaborate and troubleshoot issues. Check the schedule for upcoming co-working sessions.") . '</p>';
          return ['#markup' => $help];
        }
      Severity: Major
      Found in src/Plugin/HelpSection/ProfileResourceSection.php and 2 other locations - About 45 mins to fix
      src/Plugin/HelpSection/ProfileResourceSection.php on lines 38..42
      src/Plugin/HelpSection/ProfileResourceSection.php on lines 50..54
      Severity
      Category
      Status
      Source
      Language