Sign upLogin

SU-HKKU/cardinal_service_profile

View on GitHub
Star

Showing 66 of 150 total issues

Similar blocks of code found in 3 locations. Consider refactoring.
Open

  protected function getTechTraining() {
    $help = '<h3>' . self::getLinkString($this->t('University IT Technology Training'), 'https://itservices.stanford.edu/service/techtraining/schedule') . '</h3>';
    $help .= '<p>' . $this->t('Check the upcoming courses schedule for training courses offered to Stanford faculty and staff.') . '</p>';
    return ['#markup' => $help];
  }
Severity: Major
Found in src/Plugin/HelpSection/ProfileResourceSection.php and 2 other locations - About 45 mins to fix
src/Plugin/HelpSection/ProfileResourceSection.php on lines 50..54
src/Plugin/HelpSection/ProfileResourceSection.php on lines 62..66

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 65.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

The class SiteSettings has a coupling between objects value of 15. Consider to reduce the number of dependencies under 13.
Open

class SiteSettings extends InstallTaskBase implements ContainerFactoryPluginInterface {

  /**
   * The fallback site name.
   */
Severity: Minor
Found in src/Plugin/InstallTask/SiteSettings.php by phpmd

CouplingBetweenObjects

Since: 1.1.0

A class with too many dependencies has negative impacts on several quality aspects of a class. This includes quality criteria like stability, maintainability and understandability

Example

class Foo {
    /**
     * @var \foo\bar\X
     */
    private $x = null;

    /**
     * @var \foo\bar\Y
     */
    private $y = null;

    /**
     * @var \foo\bar\Z
     */
    private $z = null;

    public function setFoo(\Foo $foo) {}
    public function setBar(\Bar $bar) {}
    public function setBaz(\Baz $baz) {}

    /**
     * @return \SplObjectStorage
     * @throws \OutOfRangeException
     * @throws \InvalidArgumentException
     * @throws \ErrorException
     */
    public function process(\Iterator $it) {}

    // ...
}

Source https://phpmd.org/rules/design.html#couplingbetweenobjects

Doc comment short description must end with a full stop
Open

   * {@inheritDoc}
Severity: Minor
Found in src/StanfordProfilePermissions.php by phpcodesniffer

Doc comment short description must end with a full stop
Open

   * {@inheritDoc}
Severity: Minor
Found in src/Plugin/InstallTask/RouteRebuilder.php by phpcodesniffer

Doc comment short description must start with a capital letter
Open

   * {@inheritDoc}
Severity: Minor
Found in src/Plugin/InstallTask/SiteSettings.php by phpcodesniffer

Object operator not indented correctly; expected 4 spaces but found 6
Open

      ->getString() === $node->label()) {
Severity: Minor
Found in cardinal_service_profile.inc by phpcodesniffer

Doc comment short description must start with a capital letter
Open

   * {@inheritDoc}
Severity: Minor
Found in src/Plugin/InstallTask/Users.php by phpcodesniffer

Doc comment short description must end with a full stop
Open

   * {@inheritDoc}
Severity: Minor
Found in src/Plugin/InstallTask/RouteRebuilder.php by phpcodesniffer

Doc comment short description must start with a capital letter
Open

   * {@inheritDoc}
Severity: Minor
Found in src/Plugin/InstallTask/Users.php by phpcodesniffer

Doc comment short description must end with a full stop
Open

   * {@inheritDoc}
Severity: Minor
Found in src/Plugin/InstallTask/Users.php by phpcodesniffer

Doc comment short description must start with a capital letter
Open

   * {@inheritDoc}
Severity: Minor
Found in src/EventSubscriber/EventSubscriber.php by phpcodesniffer

Doc comment short description must start with a capital letter
Open

   * {@inheritDoc}
Severity: Minor
Found in src/Plugin/InstallTask/RouteRebuilder.php by phpcodesniffer

Doc comment short description must end with a full stop
Open

   * {@inheritDoc}
Severity: Minor
Found in src/Plugin/InstallTask/SiteSettings.php by phpcodesniffer

Doc comment short description must end with a full stop
Open

   * {@inheritDoc}
Severity: Minor
Found in src/Plugin/InstallTask/SiteSettings.php by phpcodesniffer

Functions must not contain multiple empty lines in a row; found 2 empty lines
Open
Severity: Minor
Found in modules/cardinal_service_profile_helper/cardinal_service_profile_helper.install by phpcodesniffer

Doc comment short description must start with a capital letter
Open

   * {@inheritDoc}
Severity: Minor
Found in src/Plugin/InstallTask/Users.php by phpcodesniffer

Doc comment short description must start with a capital letter
Open

   * {@inheritDoc}
Severity: Minor
Found in src/StanfordProfilePermissions.php by phpcodesniffer

Doc comment short description must end with a full stop
Open

   * {@inheritDoc}
Severity: Minor
Found in src/EventSubscriber/EventSubscriber.php by phpcodesniffer

Doc comment short description must start with a capital letter
Open

   * {@inheritDoc}
Severity: Minor
Found in src/Plugin/InstallTask/RouteRebuilder.php by phpcodesniffer

Doc comment short description must start with a capital letter
Open

   * {@inheritDoc}
Severity: Minor
Found in src/Plugin/InstallTask/SiteSettings.php by phpcodesniffer
Severity
Category
Status
Source
Language