Sign upLogin

SU-HKKU/cardinal_service_profile

View on GitHub
Star
modules/cardinal_service_blocks/src/EventSubscriber/BlockEventSubscriber.php

Summary

Maintainability
A
0 mins
Test Coverage
A
100%

Avoid using undefined variables such as '$events' which will lead to PHP notices.
Open

    return $events;
Severity: Minor
Found in modules/cardinal_service_blocks/src/EventSubscriber/BlockEventSubscriber.php by phpmd

UndefinedVariable

Since: 2.8.0

Detects when a variable is used that has not been defined before.

Example

class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

Source https://phpmd.org/rules/cleancode.html#undefinedvariable

Avoid using undefined variables such as '$events' which will lead to PHP notices.
Open

    $events[LayoutBuilderEvents::SECTION_COMPONENT_BUILD_RENDER_ARRAY] = [
Severity: Minor
Found in modules/cardinal_service_blocks/src/EventSubscriber/BlockEventSubscriber.php by phpmd

UndefinedVariable

Since: 2.8.0

Detects when a variable is used that has not been defined before.

Example

class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

Source https://phpmd.org/rules/cleancode.html#undefinedvariable

Avoid assigning values to variables in if clauses and the like (line '37', column '9').
Open

  public function onBuildRender(SectionComponentBuildRenderArrayEvent $event) {
    $component = $event->getComponent();
    // Action Urls are only set on views exposed filter blocks.
    // @see cardinal_service_blocks_form_layout_builder_configure_block_alter().
    if ($url = $component->getThirdPartySetting('cardinal_service_blocks', 'action_url')) {
Severity: Minor
Found in modules/cardinal_service_blocks/src/EventSubscriber/BlockEventSubscriber.php by phpmd

IfStatementAssignment

Since: 2.7.0

Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

Example

class Foo
{
    public function bar($flag)
    {
        if ($foo = 'bar') { // possible typo
            // ...
        }
        if ($baz = 0) { // always false
            // ...
        }
    }
}

Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

Doc comment short description must start with a capital letter
Invalid

   * {@inheritDoc}
Severity: Minor
Found in modules/cardinal_service_blocks/src/EventSubscriber/BlockEventSubscriber.php by phpcodesniffer

Doc comment short description must end with a full stop
Invalid

   * {@inheritDoc}
Severity: Minor
Found in modules/cardinal_service_blocks/src/EventSubscriber/BlockEventSubscriber.php by phpcodesniffer

There are no issues that match your filters.

Category
Status