SU-HKKU/cardinal_service_profile

Method getFieldTermsData has 31 lines of code (exceeds 25 allowed). Consider refactoring.

Wontfix

  protected function getFieldTermsData(FieldConfigInterface $field, $include_children = FALSE) {
    $term_storage = $this->entityTypeManager->getStorage('taxonomy_term');
    $node_storage = $this->entityTypeManager->getStorage('node');

    $data = [];

The class TermsUsedResource has a coupling between objects value of 13. Consider to reduce the number of dependencies under 13.

Wontfix

class TermsUsedResource extends ResourceBase {

  const ENTITY_TYPE = 'node';

  /**

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo {
    /**
     * @var \foo\bar\X
     */
    private $x = null;

    /**
     * @var \foo\bar\Y
     */
    private $y = null;

    /**
     * @var \foo\bar\Z
     */
    private $z = null;

    public function setFoo(\Foo $foo) {}
    public function setBar(\Bar $bar) {}
    public function setBaz(\Baz $baz) {}

    /**
     * @return \SplObjectStorage
     * @throws \OutOfRangeException
     * @throws \InvalidArgumentException
     * @throws \ErrorException
     */
    public function process(\Iterator $it) {}

    // ...
}

Missing class import via use statement (line '192', column '39').

Open

    $term_ids = iterator_to_array(new \RecursiveIteratorIterator(new \RecursiveArrayIterator($term_ids)), FALSE);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function make() {
    return new \stdClass();
}

Missing class import via use statement (line '192', column '70').

Open

    $term_ids = iterator_to_array(new \RecursiveIteratorIterator(new \RecursiveArrayIterator($term_ids)), FALSE);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function make() {
    return new \stdClass();
}

Argument 1 (field) is \Drupal\field\Entity\FieldConfig but \Drupal\cardinal_service_rest\Plugin\rest\resource\TermsUsedResource::getFieldTermsData() takes \Drupal\field\FieldConfigInterface defined at /code/modules/cardinal_service_rest/src/Plugin/rest/resource/TermsUsedResource.php:130

Invalid

        $data[$field_name] = $this->getFieldTermsData($field_definition, $include_children);

• Exclude checks
  • Disable engine
  • Disable check

Doc comment short description must start with a capital letter

Invalid

   * {@inheritDoc}

• Exclude checks
  • Disable engine
  • Disable check

Doc comment short description must end with a full stop

Invalid

   * {@inheritDoc}

• Exclude checks
  • Disable engine
  • Disable check

Doc comment short description must end with a full stop

Invalid

   * {@inheritDoc}

• Exclude checks
  • Disable engine
  • Disable check

Doc comment short description must start with a capital letter

Invalid

   * {@inheritDoc}

• Exclude checks
  • Disable engine
  • Disable check

Doc comment short description must end with a full stop

Invalid

   * {@inheritDoc}

• Exclude checks
  • Disable engine
  • Disable check

Doc comment short description must start with a capital letter

Invalid

   * {@inheritDoc}

• Exclude checks
  • Disable engine
  • Disable check