SU-SWS/stanford_migrate

View on GitHub

Showing 65 of 139 total issues

The method postImport() has a Cyclomatic Complexity of 20. The configured cyclomatic complexity threshold is 10.
Open

  public function postImport(MigrateImportEvent $event) {
    $orphan_action = $this->getOrphanAction($event->getMigration());

    // Migration doesn't have a orphan action, ignore it.
    if (!$orphan_action) {

CyclomaticComplexity

Since: 0.1

Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

Example

// Cyclomatic Complexity = 11
class Foo {
1   public function example() {
2       if ($a == $b) {
3           if ($a1 == $b1) {
                fiddle();
4           } elseif ($a2 == $b2) {
                fiddle();
            } else {
                fiddle();
            }
5       } elseif ($c == $d) {
6           while ($c == $d) {
                fiddle();
            }
7        } elseif ($e == $f) {
8           for ($n = 0; $n < $h; $n++) {
                fiddle();
            }
        } else {
            switch ($z) {
9               case 1:
                    fiddle();
                    break;
10              case 2:
                    fiddle();
                    break;
11              case 3:
                    fiddle();
                    break;
                default:
                    fiddle();
                    break;
            }
        }
    }
}

Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

syntax error, unexpected 'protected' (T_PROTECTED), expecting variable (T_VARIABLE)
Open

  public function __construct(protected EntityTypeManagerInterface $entityTypeManager, protected MigrationPluginManagerInterface $migrationPluginManager, LoggerChannelFactoryInterface $logger_factory) {
Severity: Critical
Found in src/StanfordMigrate.php by phan

Argument 2 (allowable_tags) is null but \strip_tags() takes string
Open

    return strip_tags($value, $this->configuration['allowed'] ?? NULL);

syntax error, unexpected '|', expecting ';' or '{'
Open

  protected function getImageSize(string $url): bool|array {

syntax error, unexpected '|', expecting variable (T_VARIABLE)
Open

  protected function getSourceData(string $url, string|int $item_selector = ''): array {
Severity
Category
Status
Source
Language