Sign upLogin

SU-SWS/stanford_profile_helper

View on GitHub
Star
modules/response_code_condition/src/Plugin/Condition/ResponseCodeCondition.php

Summary

Maintainability
A
0 mins
Test Coverage
A
90%

Assigning \Symfony\Component\HttpFoundation\RequestStack to property but \Drupal\response_code_condition\Plugin\Condition\ResponseCodeCondition->requestStack is \Drupal\response_code_condition\Plugin\Condition\Symfony\Component\HttpFoundation\RequestStack
Invalid

    $this->requestStack = $requestStack;
Severity: Minor
Found in modules/response_code_condition/src/Plugin/Condition/ResponseCodeCondition.php by phan

Avoid excessively long variable names like $config_response_codes. Keep variable name length under 20.
Wontfix

    $config_response_codes = explode("\n", $response_code_list);
Severity: Minor
Found in modules/response_code_condition/src/Plugin/Condition/ResponseCodeCondition.php by phpmd

LongVariable

Since: 0.2

Detects when a field, formal or local variable is declared with a long name.

Example

class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

Source https://phpmd.org/rules/naming.html#longvariable

Missing short description in doc comment
Wontfix

  /**
Severity: Minor
Found in modules/response_code_condition/src/Plugin/Condition/ResponseCodeCondition.php by phpcodesniffer

There are no issues that match your filters.

Category
Status