SU-SWS/stanford_profile_helper

View on GitHub
modules/stanford_policy/src/EventSubscriber/StanfordPolicySubscriber.php

Summary

Maintainability
A
1 hr
Test Coverage
A
93%

Method getRomanNumeral has 26 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  protected function getRomanNumeral(int $num): string {
    $map = [
      'M' => 1000,
      'CM' => 900,
      'D' => 500,

    The class StanfordPolicySubscriber has a coupling between objects value of 14. Consider to reduce the number of dependencies under 13.
    Open

    class StanfordPolicySubscriber implements EventSubscriberInterface {
    
      /**
       * Flag to prevent recursion.
       *

    CouplingBetweenObjects

    Since: 1.1.0

    A class with too many dependencies has negative impacts on several quality aspects of a class. This includes quality criteria like stability, maintainability and understandability

    Example

    class Foo {
        /**
         * @var \foo\bar\X
         */
        private $x = null;
    
        /**
         * @var \foo\bar\Y
         */
        private $y = null;
    
        /**
         * @var \foo\bar\Z
         */
        private $z = null;
    
        public function setFoo(\Foo $foo) {}
        public function setBar(\Bar $bar) {}
        public function setBaz(\Baz $baz) {}
    
        /**
         * @return \SplObjectStorage
         * @throws \OutOfRangeException
         * @throws \InvalidArgumentException
         * @throws \ErrorException
         */
        public function process(\Iterator $it) {}
    
        // ...
    }

    Source https://phpmd.org/rules/design.html#couplingbetweenobjects

    syntax error, unexpected 'protected' (T_PROTECTED), expecting variable (T_VARIABLE)
    Open

      public function __construct(protected BookManagerInterface $bookManager, protected ConfigPagesLoaderServiceInterface $configPagesLoader, protected EntityTypeManagerInterface $entityTypeManager) {

    Line indented incorrectly; expected 4 spaces, found 6
    Invalid

          'alpha_uppercase' => $letters[$position - 1],

    There are no issues that match your filters.

    Category
    Status