Sign upLogin

SU-SWS/stanford_profile_helper

View on GitHub
Star
modules/stanford_profile_drush/src/Commands/StanfordProfileCommands.php

Summary

Maintainability
A
2 hrs
Test Coverage
A
95%

Method createParagraph has 37 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  protected function createParagraph($bundle): EntityInterface {
    // We've already created this paragraph type, just duplicated i.
    if (isset($this->paragraphs[$bundle])) {
      return $this->paragraphs[$bundle]->createDuplicate();
    }
Severity: Minor
Found in modules/stanford_profile_drush/src/Commands/StanfordProfileCommands.php - About 1 hr to fix

    Function createParagraph has a Cognitive Complexity of 13 (exceeds 10 allowed). Consider refactoring.
    Open

      protected function createParagraph($bundle): EntityInterface {
    // We've already created this paragraph type, just duplicated i.
    if (isset($this->paragraphs[$bundle])) {
      return $this->paragraphs[$bundle]->createDuplicate();
    }
    Severity: Minor
    Found in modules/stanford_profile_drush/src/Commands/StanfordProfileCommands.php - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function getRowFieldValues has a Cognitive Complexity of 11 (exceeds 10 allowed). Consider refactoring.
    Wontfix

      protected function getRowFieldValues(FieldConfigInterface $field): array {
    $row_bundle = $this->getRowBundle($field);
    $row_fields = $this->fieldManager->getFieldDefinitions($field->getSetting('target_type'), $row_bundle);

    $bundle_key = $this->entityTypeManager->getDefinition($field->getSetting('target_type'))
    Severity: Minor
    Found in modules/stanford_profile_drush/src/Commands/StanfordProfileCommands.php - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid excessively long variable names like $field_type_definition. Keep variable name length under 20.
    Open

          $field_type_definition = $this->fieldTypeManager->getDefinition($field_type);
    Severity: Minor
    Found in modules/stanford_profile_drush/src/Commands/StanfordProfileCommands.php by phpmd

    LongVariable

    Since: 0.2

    Detects when a field, formal or local variable is declared with a long name.

    Example

    class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

    Source https://phpmd.org/rules/naming.html#longvariable

    There are no issues that match your filters.

    Category
    Status