Sign upLogin

SU-SWS/stanford_profile_helper

View on GitHub
Star
modules/stanford_publication/stanford_publication.module

Summary

Maintainability
Test Coverage

Avoid using undefined variables such as '$extra' which will lead to PHP notices.
Open

  return $extra;
Severity: Minor
Found in modules/stanford_publication/stanford_publication.module by phpmd

UndefinedVariable

Since: 2.8.0

Detects when a variable is used that has not been defined before.

Example

class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

Source https://phpmd.org/rules/cleancode.html#undefinedvariable

Avoid using undefined variables such as '$extra' which will lead to PHP notices.
Open

  $extra['node']['stanford_publication']['display']['citation_type'] = [
Severity: Minor
Found in modules/stanford_publication/stanford_publication.module by phpmd

UndefinedVariable

Since: 2.8.0

Detects when a variable is used that has not been defined before.

Example

class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

Source https://phpmd.org/rules/cleancode.html#undefinedvariable

Argument 1 (parent) is \Drupal\node\NodeInterface but \Drupal\stanford_publication\Entity\CitationInterface::setParentEntity() takes \Drupal\Core\Entity\ContentEntityInterface defined at /code/modules/stanford_publication/src/Entity/CitationInterface.php:67
Open

  $citation_entity->setParentEntity($entity, 'su_publication_citation')
Severity: Minor
Found in modules/stanford_publication/stanford_publication.module by phan

There are no issues that match your filters.

Category
Status