Sign upLogin

SUSE/rmt

View on GitHub
Star
engines/zypper_auth/lib/zypper_auth/engine.rb

Summary

Maintainability
A
0 mins
Test Coverage

Method verify_instance has 45 lines of code (exceeds 25 allowed). Consider refactoring.
Wontfix

    def verify_instance(request, logger, system)
      return false unless request.headers['X-Instance-Data']

      instance_data = Base64.decode64(request.headers['X-Instance-Data'].to_s)
Severity: Minor
Found in engines/zypper_auth/lib/zypper_auth/engine.rb - About 1 hr to fix

    Method verify_instance has a Cognitive Complexity of 19 (exceeds 10 allowed). Consider refactoring.
    Wontfix

        def verify_instance(request, logger, system)
      return false unless request.headers['X-Instance-Data']

      instance_data = Base64.decode64(request.headers['X-Instance-Data'].to_s)
    Severity: Minor
    Found in engines/zypper_auth/lib/zypper_auth/engine.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Wontfix

            def render_service
          status = ((request.put? || request.post?) ? 201 : 200)
          # manually setting request method, so respond_with actually renders content also for PUT
          request.instance_variable_set(:@request_method, 'GET')
    Severity: Minor
    Found in engines/zypper_auth/lib/zypper_auth/engine.rb and 1 other location - About 25 mins to fix
    app/controllers/api/connect/v3/systems/products_controller.rb on lines 166..177

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 29.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status