Sign upLogin

SUSE/rmt

View on GitHub
Star
lib/rmt/downloader.rb

Summary

Maintainability
A
3 hrs
Test Coverage

Method try_copying_from_cache has a Cognitive Complexity of 24 (exceeds 10 allowed). Consider refactoring.
Open

  def try_copying_from_cache(files, ignore_errors: false)
    # We need to verify if the cached copy is still relevant
    # Create a HTTP/HTTPS HEAD request if possible, return nil if not
    cache_requests = files.map { |file| [file, cache_head_request(file)] }.to_h
    available_in_cache = cache_requests.compact.values
Severity: Minor
Found in lib/rmt/downloader.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method create_fiber_request has a Cognitive Complexity of 17 (exceeds 10 allowed). Consider refactoring.
Wontfix

  def create_fiber_request(file_reference, failed_downloads: nil, retries: RETRIES)
    make_file_dir(file_reference.local_path)

    request_fiber = Fiber.new do
      begin
Severity: Minor
Found in lib/rmt/downloader.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method try_copying_from_cache has 33 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def try_copying_from_cache(files, ignore_errors: false)
    # We need to verify if the cached copy is still relevant
    # Create a HTTP/HTTPS HEAD request if possible, return nil if not
    cache_requests = files.map { |file| [file, cache_head_request(file)] }.to_h
    available_in_cache = cache_requests.compact.values
Severity: Minor
Found in lib/rmt/downloader.rb - About 1 hr to fix

    Method create_fiber_request has 31 lines of code (exceeds 25 allowed). Consider refactoring.
    Wontfix

      def create_fiber_request(file_reference, failed_downloads: nil, retries: RETRIES)
    make_file_dir(file_reference.local_path)

    request_fiber = Fiber.new do
      begin
    Severity: Minor
    Found in lib/rmt/downloader.rb - About 1 hr to fix

      There are no issues that match your filters.

      Category
      Status